Fix Early return when Address NAK is received (espressif#750)

stickbreaker · me-no-dev · commit 7eff707ba619 · 2017-10-21T08:40:53.000+02:00
The i2cWrite() function was returning to the app before the i2c transaction had completed.  This caused the next Wire() call to return a I2C_ERROR_BUSY.
diff --git a/cores/esp32/esp32-hal-i2c.c b/cores/esp32/esp32-hal-i2c.c
@@ -229,7 +229,7 @@ i2c_err_t i2cWrite(i2c_t * i2c, uint16_t address, bool addr_10bit, uint8_t * dat
             //Transmission did not finish and ACK_ERR is set
             if(i2c->dev->int_raw.ack_err) {
                 log_w("Ack Error! Addr: %x", address >> 1);
-                while((i2c->dev->status_reg.bus_busy) && ((millis() - startAt)>50));
+                while((i2c->dev->status_reg.bus_busy) && ((millis() - startAt)<50));
                 I2C_MUTEX_UNLOCK();
                 return I2C_ERROR_ACK;
             }

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ i2c_err_t i2cWrite(i2c_t * i2c, uint16_t address, bool addr_10bit, uint8_t * dat`
`229`	`229`	`//Transmission did not finish and ACK_ERR is set`
`230`	`230`	`if(i2c->dev->int_raw.ack_err) {`
`231`	`231`	`log_w("Ack Error! Addr: %x", address >> 1);`
`232`		`- while((i2c->dev->status_reg.bus_busy) && ((millis() - startAt)>50));`
	`232`	`+ while((i2c->dev->status_reg.bus_busy) && ((millis() - startAt)<50));`
`233`	`233`	`I2C_MUTEX_UNLOCK();`
`234`	`234`	`return I2C_ERROR_ACK;`
`235`	`235`	`}`