Skip to content

Commit 8f2c3a7

Browse files
committed
fixed __eq__ testing
1 parent d384c0d commit 8f2c3a7

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

tests/test_records.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ def test_1(self):
1717
# This comment line was manually added and is not present in the original physiobank record
1818
del(fields['comments'][0])
1919

20-
# Test file writing
2120
assert np.array_equal(siground, targetsig)
2221
assert np.array_equal(sig, pbsig) and fields == pbfields
2322

@@ -38,7 +37,7 @@ def test_2(self):
3837

3938
# Test file writing
4039
record.wrsamp()
41-
recordwrite = wfdb.rdsamp('100')
40+
recordwrite = wfdb.rdsamp('100', physical=False)
4241

4342
assert np.array_equal(sig, targetsig)
4443
assert record.__eq__(pbrecord)
@@ -95,7 +94,7 @@ def test_5(self):
9594

9695
# Test file writing
9796
record.wrsamp()
98-
recordwrite = wfdb.rdsamp('a103l')
97+
recordwrite = wfdb.rdsamp('a103l', physical=False)
9998

10099
assert np.array_equal(sig, targetsig)
101100
assert record.__eq__(pbrecord)

wfdb/annotations.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,22 +55,22 @@ def __eq__(self, other):
5555
att2 = other.__dict__
5656

5757
if set(att1.keys()) != set(att2.keys()):
58-
return False, 1
58+
return False
5959

6060
for k in att1.keys():
6161
v1 = att1[k]
6262
v2 = att2[k]
6363

6464
if type(v1) != type(v2):
65-
return False, 2
65+
return False
6666

6767
if type(v1) == np.ndarray:
6868
if not np.array_equal(v1, v2):
69-
return False, 3
69+
return False
7070
else:
7171
if v1 != v2:
7272
print(k)
73-
return False, 4
73+
return False
7474

7575
return True
7676

wfdb/records.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,21 +360,22 @@ def __eq__(self, other):
360360
att2 = other.__dict__
361361

362362
if set(att1.keys()) != set(att2.keys()):
363-
return False, 1
363+
return False
364364

365365
for k in att1.keys():
366+
366367
v1 = att1[k]
367368
v2 = att2[k]
368369

369370
if type(v1) != type(v2):
370-
return False, 2
371+
return False
371372

372373
if type(v1) == np.ndarray:
373374
if not np.array_equal(v1, v2):
374-
return False, 3
375+
return False
375376
else:
376377
if v1 != v2:
377-
return False, 4
378+
return False
378379

379380
return True
380381

0 commit comments

Comments
 (0)