Remove flag --no-dry-run for arduino-ci >= 0.14.0

hf-4145 · ianfixes · commit 83fd308afc25 · 2022-12-17T22:52:05.000-05:00
diff --git a/lib/arduino_ci/arduino_backend.rb b/lib/arduino_ci/arduino_backend.rb
@@ -211,7 +211,12 @@ def compile_sketch(path, boardname)
         @last_msg = "Can't compile Sketch at nonexistent path '#{path}'!"
         return false
       end
-      ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", path.to_s)
+      use_dry_run = should_use_dry_run?
+      if use_dry_run
+        ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", "--dry-run", path.to_s)
+      else
+        ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", path.to_s)
+      end
       @last_msg = ret[:out]
       ret[:success]
     end
@@ -299,5 +304,11 @@ def last_bytes_usage
 
       Hash[mem_info.names.map(&:to_sym).zip(mem_info.captures.map(&:to_i))]
     end
+
+    def should_use_dry_run?
+      ret = capture_json("version")
+      version = ret[:json]["VersionString"]
+      Gem::Version.new(version) < Gem::Version.new('0.14')
+    end
   end
 end
diff --git a/spec/arduino_backend_spec.rb b/spec/arduino_backend_spec.rb
@@ -110,4 +110,50 @@ def get_sketch(dir, file)
       expect(the_bytes[:max]).to eq 2048
     end
   end
+
+  context "--dry-run flags" do
+
+    sketch_path_ino = get_sketch("FakeSketch", "FakeSketch.ino")
+
+    before { allow(backend).to receive(:run_and_capture).and_call_original }
+
+    it "Uses --dry-run flag for arduino-cli version < 0.14.0" do
+      parsed_stdout = JSON.parse('{ "VersionString": "0.13.6" }')
+      cli_version_output = {
+        json: parsed_stdout
+      }
+      allow(backend).to receive(:capture_json).and_return cli_version_output
+
+      backend.compile_sketch(sketch_path_ino, "arduino:avr:uno")
+
+      expect(backend).to have_received(:run_and_capture).with(
+        "compile",
+        "--fqbn",
+        "arduino:avr:uno",
+        "--warnings",
+        "all",
+        "--dry-run",
+        sketch_path_ino.to_s
+      )
+    end
+
+    it "Does not use --dry-run flag for arduino-cli version >= 0.14.0" do
+      parsed_stdout = JSON.parse('{ "VersionString": "0.14.0" }')
+      cli_version_output = {
+        json: parsed_stdout
+      }
+      allow(backend).to receive(:capture_json).and_return cli_version_output
+
+      backend.compile_sketch(sketch_path_ino, "arduino:avr:uno")
+
+      expect(backend).to have_received(:run_and_capture).with(
+        "compile",
+        "--fqbn",
+        "arduino:avr:uno",
+        "--warnings",
+        "all",
+        sketch_path_ino.to_s
+      )
+    end
+  end
 end
