Skip to content

AVR (defined as __AVR__) should not be forced for all boards #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianfixes opened this issue Nov 10, 2020 · 1 comment
Closed

AVR (defined as __AVR__) should not be forced for all boards #202

ianfixes opened this issue Nov 10, 2020 · 1 comment
Labels
arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures

Comments

@ianfixes
Copy link
Collaborator

Issue Summary

via #144 (comment)

__AVR__ is normally defined by avr-gcc, so only for the AVR-based Arduino boards. To emulate other boards (e.g. SAMD / Arduino Zero), I think __AVR__ should not be defined, otherwise libraries etc. will not be genuinely emulated and if they test for __AVR__ they will erronously assume that all kind of AVR-specific stuff is available.

Solution: remove __AVR__ from the hard-coded argument list in cpp_library.rb and add it to the appropriate board definitions in the default.yml CI config

@ianfixes ianfixes mentioned this issue Nov 10, 2020
@ianfixes ianfixes added arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures labels Jan 2, 2021
@ianfixes
Copy link
Collaborator Author

ianfixes commented Jan 2, 2021

This seems to be completed

@ianfixes ianfixes closed this as completed Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures
Projects
None yet
Development

No branches or pull requests

1 participant