Skip to content

Added Esp32 IrSend Support #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SaheblalBagwan
Copy link

IrSend Support for ESP32
Used ledc funtions for generating IR signals.
Mapped Pin 5 for IrSend.

Used ledc funtions for generating IR signals.
Mapped Pin 5 for IrSend, which is configurable.
@z3t0
Copy link
Collaborator

z3t0 commented Aug 10, 2017

#437 Implemented a software carrier, is that sufficient?

@bengtmartensson
Copy link
Contributor

With portable software carrier (#437) in place, having sane (probably, by necessity non-portable) implementations of hardware carrier sending is a good thing. The user can then select if he wants the hard- or soft implementation. This can be valuable in many cases.

@SaheblalBagwan : I suggest that you:

  1. rewrite the patch on the top of Cleanup of hardware dependencies. Merge in SAM support.  #437 (branch beta?),
  2. write some "documentation" on your suggested solution, possibly as comments in the code. What are the ledc*-functions, and why do they solve the problem?

@z3t0
Copy link
Collaborator

z3t0 commented Aug 11, 2017

having sane (probably, by necessity non-portable) implementations of hardware carrier sending is a good thing.

True.

I'll waiting on the updates suggested above then.

@z3t0 z3t0 self-assigned this Aug 11, 2017
@z3t0 z3t0 added Enhancement Idea or request for enhancement of the library Out of Sync! and removed Waiting for Feedback labels Aug 11, 2017
@AnalysIR
Copy link
Contributor

AFAIK 'ledc' is one standard method to generate PWM on the ESP32.
(ledc => LED Control Peripheral.....IR emitter is another LED)
There is also a dedicated IR RxTx peripheral on the ESP32, which would be the ultimate end game for this particular platform wrt IR (...and somewhat over-kill/over-engineered).

On most platforms, I would suggest that hardware based PWM for generating the carrier is a better approach than 'softPWM'. In other words, I would recommend 'hardPWM' over 'softPWM' in most cases, unless:
A - it is not available
B - specific pins/peripherals/interrupts/resources are not available for use.

@Vorms
Copy link

Vorms commented Feb 21, 2018

Hello, what's about a compatible IR remote library using RMT peripheral?

@marcmerlin
Copy link
Contributor

Just to check, is there any code for RMT IR Receive on ESP32? I've only found IR send using RMT so far.

@Vorms
Copy link

Vorms commented Aug 21, 2018 via email

@ArminJo
Copy link
Collaborator

ArminJo commented Jul 3, 2020

ESP32 send support is now included.

@ArminJo ArminJo closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Idea or request for enhancement of the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants