robot-name: added new test (exercism#2065)

cdpaiva · jmrunkle · web-flow · commit 37eff0bb61b5 · 2021-12-09T15:13:12.000-08:00
* New test for Robot Name

* Update Robot.java

* Update Robot.java

* Update RobotTest.java

* Update RobotTest.java

* Update exercises/practice/robot-name/src/test/java/RobotTest.java

Co-authored-by: Jason Runkle &lt;jmrunkle@gmail.com&gt;

* Removed recursive call

* Update exercises/practice/robot-name/src/test/java/RobotTest.java

Co-authored-by: Jason Runkle &lt;jmrunkle@gmail.com&gt;

Co-authored-by: Jason Runkle &lt;jmrunkle@gmail.com&gt;
diff --git a/exercises/practice/robot-name/.meta/src/reference/java/Robot.java b/exercises/practice/robot-name/.meta/src/reference/java/Robot.java
@@ -1,18 +1,25 @@
+import java.util.HashSet;
 import java.util.Random;
+import java.util.Set;
 
 public class Robot {
 
     private static final String ALPHABET = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
     private String name;
     private final Random random;
+    private static Set<String> nameLog = new HashSet<>();
 
     public Robot() {
         random = new Random();
         assignNewName();
     }
 
     private void assignNewName() {
-        name = String.format("%s%d", prefix(), suffix());
+        String newName = String.format("%s%d", prefix(), suffix());
+        while (!nameLog.add(newName)) {
+            newName = String.format("%s%d", prefix(), suffix());
+        }
+        this.name = newName;
     }
 
     public String getName() {
diff --git a/exercises/practice/robot-name/src/test/java/RobotTest.java b/exercises/practice/robot-name/src/test/java/RobotTest.java
@@ -1,8 +1,11 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
-import org.junit.Test;
-import org.junit.Ignore;
+import java.util.HashSet;
+import java.util.Set;
+
 import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Test;
 
 public class RobotTest {
 
@@ -34,6 +37,17 @@ public void resetName() {
         assertThat(name).isNotEqualTo(name2);
         assertIsValidName(name2);
     }
+    
+    @Ignore("Remove to run test")
+    @Test
+    public void robotNamesAreUnique() {
+        Set<String> robotNames = new HashSet<>();
+        int sampleSize = 5000;
+        for (int i = 0; i < sampleSize; i++) {
+            robotNames.add(new Robot().getName());
+        }
+        assertThat(robotNames).hasSize(sampleSize);
+    }
 
     private static void assertIsValidName(String name) {
         assertThat(name).matches(EXPECTED_ROBOT_NAME_PATTERN);
