refactor: iluwatar#1012 - Resolve Sonar report: missing assertions in several AppTest classes (iluwatar#1784)

samuelpsouza · ohbus · web-flow · commit 43e7ca515ae7 · 2021-06-07T22:30:44.000+05:30
Co-authored-by: Subhrodip Mohanta &lt;hello@subho.xyz&gt;
diff --git a/filterer/src/test/java/com/iluwatar/filterer/AppTest.java b/filterer/src/test/java/com/iluwatar/filterer/AppTest.java
@@ -23,11 +23,14 @@
 
 package com.iluwatar.filterer;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 class AppTest {
+
   @Test
   void shouldLaunchApp() {
-    App.main(new String[]{});
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/monad/src/test/java/com/iluwatar/monad/AppTest.java b/monad/src/test/java/com/iluwatar/monad/AppTest.java
@@ -23,16 +23,19 @@
 
 package com.iluwatar.monad;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
  * Application Test
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void testMain() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 
 }
diff --git a/monostate/src/test/java/com/iluwatar/monostate/AppTest.java b/monostate/src/test/java/com/iluwatar/monostate/AppTest.java
@@ -23,16 +23,19 @@
 
 package com.iluwatar.monostate;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
  * Application Test Entry
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void testMain() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 
 }
diff --git a/multiton/src/test/java/com/iluwatar/multiton/AppTest.java b/multiton/src/test/java/com/iluwatar/multiton/AppTest.java
@@ -23,15 +23,18 @@
 
 package com.iluwatar.multiton;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
- * Application test
+ * Test if the application starts without throwing an exception.
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void test() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/object-pool/src/test/java/com/iluwatar/object/pool/AppTest.java b/object-pool/src/test/java/com/iluwatar/object/pool/AppTest.java
@@ -23,6 +23,8 @@
 
 package com.iluwatar.object.pool;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
@@ -34,6 +36,6 @@ class AppTest {
 
   @Test
   void shouldExecuteApplicationWithoutException() {
-    App.main(new String[]{});
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java b/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
@@ -23,19 +23,16 @@
 
 package com.iluwatar.parameter.object;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Application test
  */
 class AppTest {
-  private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class);
-
   @Test
   void shouldExecuteApplicationWithoutException() {
-    App.main(new String[]{});
-    LOGGER.info("Executed successfully without exception.");
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/saga/src/test/java/com/iluwatar/saga/orchestration/SagaApplicationTest.java b/saga/src/test/java/com/iluwatar/saga/orchestration/SagaApplicationTest.java
@@ -23,15 +23,17 @@
 
 package com.iluwatar.saga.orchestration;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
- * empty test
+ * Test if the application starts without throwing an exception.
  */
 class SagaApplicationTest {
 
   @Test
-  void mainTest() {
-    SagaApplication.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> SagaApplication.main(new String[]{}));
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,14 @@`
`23`	`23`
`24`	`24`	`package com.iluwatar.filterer;`
`25`	`25`
	`26`	`+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;`
	`27`	`+`
`26`	`28`	`import org.junit.jupiter.api.Test;`
`27`	`29`
`28`	`30`	`class AppTest {`
	`31`	`+`
`29`	`32`	`@Test`
`30`	`33`	`void shouldLaunchApp() {`
`31`		`- App.main(new String[]{});`
	`34`	`+ assertDoesNotThrow(() -> App.main(new String[]{}));`
`32`	`35`	`}`
`33`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`
`24`	`24`	`package com.iluwatar.object.pool;`
`25`	`25`
	`26`	`+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;`
	`27`	`+`
`26`	`28`	`import org.junit.jupiter.api.Test;`
`27`	`29`
`28`	`30`	`/**`
`@@ -34,6 +36,6 @@ class AppTest {`
`34`	`36`
`35`	`37`	`@Test`
`36`	`38`	`void shouldExecuteApplicationWithoutException() {`
`37`		`- App.main(new String[]{});`
	`39`	`+ assertDoesNotThrow(() -> App.main(new String[]{}));`
`38`	`40`	`}`
`39`	`41`	`}`