iluwatar#1284 Use local variable inference

Pavel Manannikov · Pavel Manannikov · commit 97e3a3debcb6 · 2020-11-23T19:42:50.000+02:00
diff --git a/version-number/README.md b/version-number/README.md
@@ -78,7 +78,7 @@ public class BookRepository {
       throw new BookNotFoundException("Not found book with id: " + book.getId());
     }
 
-    Book latestBook = collection.get(book.getId());
+    var latestBook = collection.get(book.getId());
     if (book.getVersion() != latestBook.getVersion()) {
       throw new VersionMismatchException(
         "Tried to update stale version " + book.getVersion()
@@ -107,10 +107,10 @@ public class BookRepository {
 Here's the concurrency control in action:
 
 ```java
-long bookId = 1;
+var bookId = 1;
 // Alice and Bob took the book concurrently
-final Book aliceBook = bookRepository.get(bookId);
-final Book bobBook = bookRepository.get(bookId);
+final var aliceBook = bookRepository.get(bookId);
+final var bobBook = bookRepository.get(bookId);
 
 aliceBook.setTitle("Kama Sutra"); // Alice has updated book title
 bookRepository.update(aliceBook); // and successfully saved book in database
diff --git a/version-number/src/main/java/com/iluwatar/versionnumber/App.java b/version-number/src/main/java/com/iluwatar/versionnumber/App.java
@@ -53,17 +53,17 @@ public static void main(String[] args) throws
       BookDuplicateException,
       BookNotFoundException,
       VersionMismatchException {
-    long bookId = 1;
+    var bookId = 1;
 
-    BookRepository bookRepository = new BookRepository();
-    Book book = new Book();
+    var bookRepository = new BookRepository();
+    var book = new Book();
     book.setId(bookId);
     bookRepository.add(book); // adding a book with empty title and author
     LOGGER.info("An empty book with version {} was added to repository", book.getVersion());
 
     // Alice and Bob took the book concurrently
-    final Book aliceBook = bookRepository.get(bookId);
-    final Book bobBook = bookRepository.get(bookId);
+    final var aliceBook = bookRepository.get(bookId);
+    final var bobBook = bookRepository.get(bookId);
 
     aliceBook.setTitle("Kama Sutra"); // Alice has updated book title
     bookRepository.update(aliceBook); // and successfully saved book in database
diff --git a/version-number/src/main/java/com/iluwatar/versionnumber/BookRepository.java b/version-number/src/main/java/com/iluwatar/versionnumber/BookRepository.java
@@ -56,7 +56,7 @@ public void update(Book book) throws BookNotFoundException, VersionMismatchExcep
       throw new BookNotFoundException("Not found book with id: " + book.getId());
     }
 
-    Book latestBook = collection.get(book.getId());
+    var latestBook = collection.get(book.getId());
     if (book.getVersion() != latestBook.getVersion()) {
       throw new VersionMismatchException(
         "Tried to update stale version " + book.getVersion()
diff --git a/version-number/src/test/java/com/iluwatar/versionnumber/BookRepositoryTest.java b/version-number/src/test/java/com/iluwatar/versionnumber/BookRepositoryTest.java
@@ -33,17 +33,17 @@
 class BookRepositoryTest {
   @Test
   void testBookRepository() throws BookDuplicateException, BookNotFoundException, VersionMismatchException {
-    final long bookId = 1;
+    final var bookId = 1;
 
-    BookRepository bookRepository = new BookRepository();
-    Book book = new Book();
+    var bookRepository = new BookRepository();
+    var book = new Book();
     book.setId(bookId);
     bookRepository.add(book);
 
     assertEquals(0, book.getVersion());
 
-    final Book aliceBook = bookRepository.get(bookId);
-    final Book bobBook = bookRepository.get(bookId);
+    final var aliceBook = bookRepository.get(bookId);
+    final var bobBook = bookRepository.get(bookId);
 
     assertEquals(aliceBook.getTitle(), bobBook.getTitle());
     assertEquals(aliceBook.getAuthor(), bobBook.getAuthor());

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public void update(Book book) throws BookNotFoundException, VersionMismatchExcep`
`56`	`56`	`throw new BookNotFoundException("Not found book with id: " + book.getId());`
`57`	`57`	`}`
`58`	`58`
`59`		`- Book latestBook = collection.get(book.getId());`
	`59`	`+ var latestBook = collection.get(book.getId());`
`60`	`60`	`if (book.getVersion() != latestBook.getVersion()) {`
`61`	`61`	`throw new VersionMismatchException(`
`62`	`62`	`"Tried to update stale version " + book.getVersion()`