Skip to content

Commit a3c4d36

Browse files
venkatrs-ch197cherukumilliv
and
cherukumilliv
authored
Added Java 11 support and created constants in App.java (iluwatar#1238)
Co-authored-by: cherukumilliv <VenkatRamaSubbarago.Cherukumilli@Cevalogistics.com>
1 parent 1c26bd7 commit a3c4d36

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

module/src/main/java/com/iluwatar/module/App.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
*/
3838
public class App {
3939

40+
private static final String ERROR = "Error";
41+
private static final String MESSAGE = "Message";
4042
public static FileLoggerModule fileLoggerModule;
4143
public static ConsoleLoggerModule consoleLoggerModule;
4244

@@ -71,12 +73,12 @@ public static void unprepare() {
7173
public static void execute(final String... args) {
7274

7375
/* Send logs on file system */
74-
fileLoggerModule.printString("Message");
75-
fileLoggerModule.printErrorString("Error");
76+
fileLoggerModule.printString(MESSAGE);
77+
fileLoggerModule.printErrorString(ERROR);
7678

7779
/* Send logs on console */
78-
consoleLoggerModule.printString("Message");
79-
consoleLoggerModule.printErrorString("Error");
80+
consoleLoggerModule.printString(MESSAGE);
81+
consoleLoggerModule.printErrorString(ERROR);
8082
}
8183

8284
/**

module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public final class FileLoggerModuleTest {
6565
public void testFileMessage() throws IOException {
6666

6767
/* Get singletong instance of File Logger Module */
68-
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
68+
final var fileLoggerModule = FileLoggerModule.getSingleton();
6969

7070
/* Prepare the essential sub modules, to perform the sequence of jobs */
7171
fileLoggerModule.prepare();
@@ -89,7 +89,7 @@ public void testFileMessage() throws IOException {
8989
public void testNoFileMessage() throws IOException {
9090

9191
/* Get singletong instance of File Logger Module */
92-
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
92+
final var fileLoggerModule = FileLoggerModule.getSingleton();
9393

9494
/* Prepare the essential sub modules, to perform the sequence of jobs */
9595
fileLoggerModule.prepare();
@@ -111,7 +111,7 @@ public void testNoFileMessage() throws IOException {
111111
public void testFileErrorMessage() throws FileNotFoundException {
112112

113113
/* Get singletong instance of File Logger Module */
114-
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
114+
final var fileLoggerModule = FileLoggerModule.getSingleton();
115115

116116
/* Prepare the essential sub modules, to perform the sequence of jobs */
117117
fileLoggerModule.prepare();
@@ -136,7 +136,7 @@ public void testFileErrorMessage() throws FileNotFoundException {
136136
public void testNoFileErrorMessage() throws FileNotFoundException {
137137

138138
/* Get singletong instance of File Logger Module */
139-
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
139+
final var fileLoggerModule = FileLoggerModule.getSingleton();
140140

141141
/* Prepare the essential sub modules, to perform the sequence of jobs */
142142
fileLoggerModule.prepare();
@@ -157,7 +157,7 @@ public void testNoFileErrorMessage() throws FileNotFoundException {
157157
private static final String readFirstLine(final String file) {
158158

159159
String firstLine = null;
160-
try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
160+
try (var bufferedReader = new BufferedReader(new FileReader(file))) {
161161

162162
while (bufferedReader.ready()) {
163163

0 commit comments

Comments
 (0)