Fix sonar issues

VictorZZZZ · VictorZZZZ · commit dabe4d2022fd · 2021-08-27T13:27:50.000+03:00
diff --git a/caching/src/main/java/com/iluwatar/caching/App.java b/caching/src/main/java/com/iluwatar/caching/App.java
@@ -85,13 +85,14 @@ public static void main(final String[] args) {
         // installed and socket connection is open).
         App app = new App(isDbMongo(args));
         app.useReadAndWriteThroughStrategy();
-        System.out.println("==============================================");
+        String splitLine = "==============================================";
+        LOGGER.info(splitLine);
         app.useReadThroughAndWriteAroundStrategy();
-        System.out.println("==============================================");
+        LOGGER.info(splitLine);
         app.useReadThroughAndWriteBehindStrategy();
-        System.out.println("==============================================");
+        LOGGER.info(splitLine);
         app.useCacheAsideStategy();
-        System.out.println("==============================================");
+        LOGGER.info(splitLine);
     }
 
     /**
diff --git a/caching/src/main/java/com/iluwatar/caching/AppManager.java b/caching/src/main/java/com/iluwatar/caching/AppManager.java
@@ -26,6 +26,7 @@
 import java.util.Optional;
 
 import com.iluwatar.caching.database.DbManager;
+import lombok.Data;
 import lombok.extern.slf4j.Slf4j;
 
 /**
@@ -37,11 +38,12 @@
  * appropriate function in the CacheStore class.
  */
 @Slf4j
+@Data
 public class AppManager {
   /**
    * Caching Policy.
    */
-  private static CachingPolicy cachingPolicy;
+  private CachingPolicy cachingPolicy;
   /**
    * Database Manager.
    */
diff --git a/caching/src/main/java/com/iluwatar/caching/CacheStore.java b/caching/src/main/java/com/iluwatar/caching/CacheStore.java
@@ -43,11 +43,11 @@ public class CacheStore {
   /**
    * Lru cache see {@link LruCache}.
    */
-  private static LruCache cache;
+  private LruCache cache;
   /**
    * DbManager.
    */
-  private DbManager dbManager;
+  private final DbManager dbManager;
 
   /**
    * Cache Store.
diff --git a/caching/src/main/java/com/iluwatar/caching/database/MongoDb.java b/caching/src/main/java/com/iluwatar/caching/database/MongoDb.java
@@ -45,7 +45,7 @@ public UserAccount readFromDb(final String userId) {
         var iterable = db
                 .getCollection(CachingConstants.USER_ACCOUNT)
                 .find(new Document(USER_ID, userId));
-        if (iterable == null) {
+        if (iterable.first()==null) {
             return null;
         }
         Document doc = iterable.first();
diff --git a/caching/src/main/java/com/iluwatar/caching/database/VirtualDb.java b/caching/src/main/java/com/iluwatar/caching/database/VirtualDb.java
@@ -13,14 +13,14 @@ public class VirtualDb implements DbManager {
     /**
      * Virtual DataBase.
      */
-    private Map<String, UserAccount> virtualDB;
+    private Map<String, UserAccount> db;
 
     /**
      * Creates new HashMap.
      */
     @Override
     public void connect() {
-        virtualDB = new HashMap<>();
+        db = new HashMap<>();
     }
 
     /**
@@ -30,8 +30,8 @@ public void connect() {
      */
     @Override
     public UserAccount readFromDb(final String userId) {
-        if (virtualDB.containsKey(userId)) {
-            return virtualDB.get(userId);
+        if (db.containsKey(userId)) {
+            return db.get(userId);
         }
         return null;
     }
@@ -43,7 +43,7 @@ public UserAccount readFromDb(final String userId) {
      */
     @Override
     public UserAccount writeToDb(final UserAccount userAccount) {
-        virtualDB.put(userAccount.getUserId(), userAccount);
+        db.put(userAccount.getUserId(), userAccount);
         return userAccount;
     }
 
@@ -54,8 +54,7 @@ public UserAccount writeToDb(final UserAccount userAccount) {
      */
     @Override
     public UserAccount updateDb(final UserAccount userAccount) {
-        virtualDB.put(userAccount.getUserId(), userAccount);
-        return userAccount;
+        return writeToDb(userAccount);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public UserAccount readFromDb(final String userId) {`
`45`	`45`	`var iterable = db`
`46`	`46`	`.getCollection(CachingConstants.USER_ACCOUNT)`
`47`	`47`	`.find(new Document(USER_ID, userId));`
`48`		`- if (iterable == null) {`
	`48`	`+ if (iterable.first()==null) {`
`49`	`49`	`return null;`
`50`	`50`	`}`
`51`	`51`	`Document doc = iterable.first();`