Skip to content

Create snippet for Material Autocomplete is outdated (mat-autocomplete and mat-autocomplete$) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sultanmyrza opened this issue Aug 17, 2019 · 1 comment
Open

Create snippet for Material Autocomplete is outdated (mat-autocomplete and mat-autocomplete$) #114

sultanmyrza opened this issue Aug 17, 2019 · 1 comment

Comments

@sultanmyrza
Copy link

current auto generated code for mat-autocomplete is outdated

actual

<mat-input-container floatPlaceholder="always">
    <input matInput placeholder="" [matAutocomplete]="autocompleteTemplateRefId"
           formControlName="formControlName">
</mat-input-container>

<mat-autocomplete #autocompleteTemplateRefId="matAutocomplete"
                  [displayWith]="onSelectConvertValueToInputFn">
    <mat-option *ngFor="let choice of choices | async" [value]="choice">
        Choice shown in dropdown
    </mat-option>
</mat-autocomplete>

expected

<mat-form-field floatLabel="always">
    <input matInput placeholder="" [matAutocomplete]="autocompleteTemplateRefId"
           formControlName="formControlName">
</mat-form-field>

<mat-autocomplete #autocompleteTemplateRefId="matAutocomplete"
                  [displayWith]="onSelectConvertValueToInputFn">
    <mat-option *ngFor="let choice of choices | async" [value]="choice">
        Choice shown in dropdown
    </mat-option>
</mat-autocomplete>

now instead mat-input-container we use mat-form-field
because breaking changes
https://github.com/angular/components/blob/master/CHANGELOG.md#600-beta5-2018-03-23

and for floatPlaceholder we use floatLabel
more info https://stackoverflow.com/a/48540947

I really enjoy using these code snippets please fix as soon as possible or let me know how can I fix myself and create pull-request
@Frankystan
Copy link

I agree. It should be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sultanmyrza @Frankystan