fix: Allow fetching of non-personal workspaces (coder#1495)

kylecarbs · web-flow · commit 9b1ef2969483 · 2022-05-16T22:47:31.000Z
RBAC should cover this anyways!
diff --git a/coderd/httpmw/workspaceparam.go b/coderd/httpmw/workspaceparam.go
@@ -44,14 +44,6 @@ func ExtractWorkspaceParam(db database.Store) func(http.Handler) http.Handler {
 				return
 			}
 
-			apiKey := APIKey(r)
-			if apiKey.UserID != workspace.OwnerID {
-				httpapi.Write(rw, http.StatusUnauthorized, httpapi.Response{
-					Message: "getting non-personal workspaces isn't supported",
-				})
-				return
-			}
-
 			ctx := context.WithValue(r.Context(), workspaceParamContextKey{}, workspace)
 			next.ServeHTTP(rw, r.WithContext(ctx))
 		})
diff --git a/coderd/httpmw/workspaceparam_test.go b/coderd/httpmw/workspaceparam_test.go
@@ -92,31 +92,6 @@ func TestWorkspaceParam(t *testing.T) {
 		require.Equal(t, http.StatusNotFound, res.StatusCode)
 	})
 
-	t.Run("NonPersonal", func(t *testing.T) {
-		t.Parallel()
-		db := databasefake.New()
-		rtr := chi.NewRouter()
-		rtr.Use(
-			httpmw.ExtractAPIKey(db, nil),
-			httpmw.ExtractWorkspaceParam(db),
-		)
-		rtr.Get("/", nil)
-		r, _ := setup(db)
-		workspace, err := db.InsertWorkspace(context.Background(), database.InsertWorkspaceParams{
-			ID:      uuid.New(),
-			OwnerID: uuid.New(),
-			Name:    "hello",
-		})
-		require.NoError(t, err)
-		chi.RouteContext(r.Context()).URLParams.Add("workspace", workspace.ID.String())
-		rw := httptest.NewRecorder()
-		rtr.ServeHTTP(rw, r)
-
-		res := rw.Result()
-		defer res.Body.Close()
-		require.Equal(t, http.StatusUnauthorized, res.StatusCode)
-	})
-
 	t.Run("Found", func(t *testing.T) {
 		t.Parallel()
 		db := databasefake.New()
