Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/NativeScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: Cacodaimon/NativeScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 19, 2019

  1. Do not try to parse JSON if response body is empty. 

    Otherwise JSON.parse throws "SyntaxError: Unexpected end of JSON input" which result in ommited HTTP response headers.
Firefox and Chrome do not ommit the headers when doing the same XMLHttpRequest.
Sending an empty body with JSON as content type is not wrong in my option when doing a POST returning a 201 (e.g. Created) with a proper Location header leading to the created resource as JSON.
    @Cacodaimon
    Cacodaimon committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e57fd1e View commit details
    Browse the repository at this point in the history
Loading