Skip to content

Commit 00d1a8b

Browse files
committed
Changing some commented out metrics to avoid future gotchas.
1 parent e010669 commit 00d1a8b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

kafka/consumer/fetcher.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ def __init__(self, metrics, prefix):
681681
self.fetch_latency.add(metrics.metricName("fetch-latency-max", self.group_name,
682682
"The max time taken for any fetch request."), metrics.Max())
683683
self.fetch_latency.add(metrics.metricName("fetch-rate", self.group_name,
684-
"The number of fetch requests per second."), metrics.Rate(metrics.Count()))
684+
"The number of fetch requests per second."), metrics.Rate(sampled_stat=metrics.Count()))
685685
686686
self.records_fetch_lag = metrics.sensor("records-lag")
687687
self.records_fetch_lag.add(metrics.metricName("records-lag-max", self.group_name,

kafka/coordinator/base.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ def __init__(self, metrics, prefix, tags=None):
658658
self.heartbeat_latency.add(metrics.metricName(
659659
"heartbeat-rate", self.group_name,
660660
"The average number of heartbeats per second",
661-
tags), metrics.Rate(metrics.Count()))
661+
tags), metrics.Rate(sampled_stat=metrics.Count()))
662662
663663
self.join_latency = metrics.sensor("join-latency")
664664
self.join_latency.add(metrics.metricName(
@@ -672,7 +672,7 @@ def __init__(self, metrics, prefix, tags=None):
672672
self.join_latency.add(metrics.metricName(
673673
"join-rate", self.group_name,
674674
"The number of group joins per second",
675-
tags), metrics.Rate(metrics.Count()))
675+
tags), metrics.Rate(sampled_stat=metrics.Count()))
676676
677677
self.sync_latency = metrics.sensor("sync-latency")
678678
self.sync_latency.add(metrics.metricName(
@@ -686,7 +686,7 @@ def __init__(self, metrics, prefix, tags=None):
686686
self.sync_latency.add(metrics.metricName(
687687
"sync-rate", self.group_name,
688688
"The number of group syncs per second",
689-
tags), metrics.Rate(metrics.Count()))
689+
tags), metrics.Rate(sampled_stat=metrics.Count()))
690690
691691
"""
692692
lastHeartbeat = Measurable(

0 commit comments

Comments
 (0)