Update base.py

twm · twm · commit 00d527f48029 · 2016-02-26T17:37:41.000-08:00
Our app uses `SimpleProducer` and logs lots of these warnings (from line 438):

   producer.stop() called, but producer is not async

This destructor appears to be the cause.

(Also, is it wise to do a thread join from a destructor?)
diff --git a/kafka/producer/base.py b/kafka/producer/base.py
@@ -471,5 +471,5 @@ def stop(self, timeout=None):
         self.stopped = True
 
     def __del__(self):
-        if not self.stopped:
+        if self.async and not self.stopped:
             self.stop()
