Mock client.ready() call to test coordinator offset fetch request

dpkp · dpkp · commit 29e96f82ce0b · 2016-02-19T07:56:44.000-08:00
diff --git a/kafka/coordinator/consumer.py b/kafka/coordinator/consumer.py
@@ -563,7 +563,8 @@ def _send_offset_fetch_request(self, partitions):
 
         # Verify node is ready
         if not self._client.ready(node_id):
-            log.debug("Node %s not ready -- failing offset fetch request")
+            log.debug("Node %s not ready -- failing offset fetch request",
+                      node_id)
             return Future().failure(Errors.NodeNotReadyError)
 
         log.debug("Fetching committed offsets for partitions: %s", partitions)
diff --git a/test/test_coordinator.py b/test/test_coordinator.py
@@ -385,6 +385,7 @@ def patched_coord(mocker, coordinator):
     coordinator.coordinator_id = 0
     mocker.patch.object(coordinator._client, 'least_loaded_node',
                         return_value=1)
+    mocker.patch.object(coordinator._client, 'ready', return_value=True)
     mocker.patch.object(coordinator._client, 'send')
     mocker.spy(coordinator, '_failed_request')
     mocker.spy(coordinator, '_handle_offset_commit_response')
