Internal change to ensure that all connections in a pool have been

anthony-tuininga · anthony-tuininga · commit 86032f96bae1 · 2023-12-09T12:08:00.000-07:00
closed gracefaully before the pool is closed.
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -28,6 +28,8 @@ Thin Mode Changes
 #)  Added support for the ``FAILOVER`` clause in full connect descriptors.
 #)  A more meaningful error is raised when the wrong type of data is passed to
     :meth:`LOB.write()`.
+#)  Internal change to ensure that all connections in a pool have been closed
+    gracefully before the pool is closed.
 #)  Internal changes to improve handling of the network protocol between
     python-oracledb and Oracle Database.
 #)  Internal changes to improve handling of multiple address and description
diff --git a/src/oracledb/impl/thin/pool.pyx b/src/oracledb/impl/thin/pool.pyx
@@ -143,8 +143,8 @@ cdef class ThinPoolImpl(BasePoolImpl):
                 wait = False
                 self._drop_conn_impls_helper(conn_impls_to_drop)
 
-            # if pool has closed, stop thread!
-            if not self._open:
+            # if pool has closed and no connections to drop, stop thread!
+            if not self._open and not self._conn_impls_to_drop:
                 break
 
             # otherwise, if nothing needed to be done, wait for notification
