BUG21414628: Fix failing C extension unittests

peeyushgupta · peeyushgupta · commit b460c85fcbbe · 2015-07-22T20:43:22.000+05:30
We fix unittests failing with C extension with this patch.
diff --git a/lib/mysql/connector/connection_cext.py b/lib/mysql/connector/connection_cext.py
@@ -187,7 +187,7 @@ def close(self):
     def is_connected(self):
         """Reports whether the connection to MySQL Server is available"""
         if self._cmysql:
-            return self._cmysql.connected()
+            return self._cmysql.ping()
 
         return False
 
@@ -208,12 +208,17 @@ def ping(self, reconnect=False, attempts=1, delay=0):
         errmsg = "Connection to MySQL is not available"
 
         try:
-            self._cmysql.ping()
+            connected = self._cmysql.ping()
         except AttributeError:
-            if reconnect:
-                self.reconnect(attempts=attempts, delay=delay)
-            else:
-                raise errors.InterfaceError(errmsg)
+          pass  # Raise or reconnect later
+        else:
+            if connected:
+                return
+
+        if reconnect:
+            self.reconnect(attempts=attempts, delay=delay)
+        else:
+            raise errors.InterfaceError(errmsg)
 
     def set_character_set_name(self, charset):
         """Sets the default character set name for current connection.
