chore: serialize None into null instead of undefined (microsoft#694)

mxschmitt · web-flow · commit a60b20f1537b · 2021-05-17T00:27:20.000+02:00
diff --git a/playwright/_impl/_js_handle.py b/playwright/_impl/_js_handle.py
@@ -98,7 +98,7 @@ def serialize_value(value: Any, handles: List[JSHandle], depth: int) -> Any:
     if depth > 100:
         raise Error("Maximum argument depth exceeded")
     if value is None:
-        return dict(v="undefined")
+        return dict(v="null")
     if isinstance(value, float):
         if value == float("inf"):
             return dict(v="Infinity")
diff --git a/tests/async/test_evaluate.py b/tests/async/test_evaluate.py
@@ -142,7 +142,7 @@ async def test_evaluate_return_complex_objects(page):
 
 async def test_evaluate_accept_none_as_one_of_multiple_parameters(page):
     result = await page.evaluate(
-        '({ a, b }) => Object.is(a, undefined) && Object.is(b, "foo")',
+        '({ a, b }) => Object.is(a, null) && Object.is(b, "foo")',
         {"a": None, "b": "foo"},
     )
     assert result

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ async def test_evaluate_return_complex_objects(page):`
`142`	`142`
`143`	`143`	`async def test_evaluate_accept_none_as_one_of_multiple_parameters(page):`
`144`	`144`	`result = await page.evaluate(`
`145`		`- '({ a, b }) => Object.is(a, undefined) && Object.is(b, "foo")',`
	`145`	`+ '({ a, b }) => Object.is(a, null) && Object.is(b, "foo")',`
`146`	`146`	`{"a": None, "b": "foo"},`
`147`	`147`	`)`
`148`	`148`	`assert result`