changing affectDynamic updates lighting (playcanvas#2894)

mvaligursky · web-flow · commit 202f61b30093 · 2021-02-19T17:57:48.000Z
diff --git a/src/framework/components/light/component.js b/src/framework/components/light/component.js
@@ -432,6 +432,7 @@ function _defineProps() {
         } else {
             this.light.mask &= ~MASK_DYNAMIC;
         }
+        this.light.layersDirty();
     });
     _defineProperty("affectLightmapped", false, function (newValue, oldValue) {
         if (newValue) {
diff --git a/src/scene/light.js b/src/scene/light.js
@@ -281,6 +281,10 @@ class Light {
         }
     }
 
+    layersDirty() {
+        this._scene.layers._dirtyLights = true;
+    }
+
     updateKey() {
         // Key definition:
         // Bit
@@ -315,7 +319,7 @@ class Light {
         }
 
         if (key !== this.key && this._scene !== null) {
-            this._scene.layers._dirtyLights = true;
+            this.layersDirty();
         }
 
         this.key = key;

Original file line number	Diff line number	Diff line change
`@@ -432,6 +432,7 @@ function _defineProps() {`
`432`	`432`	`} else {`
`433`	`433`	`this.light.mask &= ~MASK_DYNAMIC;`
`434`	`434`	`}`
	`435`	`+ this.light.layersDirty();`
`435`	`436`	`});`
`436`	`437`	`_defineProperty("affectLightmapped", false, function (newValue, oldValue) {`
`437`	`438`	`if (newValue) {`
Original file line number	Diff line number	Diff line change
`@@ -281,6 +281,10 @@ class Light {`
`281`	`281`	`}`
`282`	`282`	`}`
`283`	`283`
	`284`	`+ layersDirty() {`
	`285`	`+ this._scene.layers._dirtyLights = true;`
	`286`	`+ }`
	`287`	`+`
`284`	`288`	`updateKey() {`
`285`	`289`	`// Key definition:`
`286`	`290`	`// Bit`
`@@ -315,7 +319,7 @@ class Light {`
`315`	`319`	`}`
`316`	`320`
`317`	`321`	`if (key !== this.key && this._scene !== null) {`
`318`		`- this._scene.layers._dirtyLights = true;`
	`322`	`+ this.layersDirty();`
`319`	`323`	`}`
`320`	`324`
`321`	`325`	`this.key = key;`