fixup! Add App.enableComponent and App.updateComponent for Widevine support

rogerwang · rogerwang · commit 0e5c43944915 · 2021-01-19T00:20:08.000-07:00
diff --git a/src/api/nw_app_api.cc b/src/api/nw_app_api.cc
@@ -122,7 +122,7 @@ void NwAppEnableComponentFunction::OnRegistered() {
   }
   auto result_value = std::make_unique<base::Value>(ret);
 
-  Respond(OneArgument(std::move(result_value)));
+  Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));
 }
 
 ExtensionFunction::ResponseAction
@@ -138,10 +138,10 @@ void NwAppUpdateComponentFunction::OnUpdated(update_client::Error error) {
   bool ret = (error == update_client::Error::NONE);
   auto result_value = std::make_unique<base::Value>(ret);
   if (ret) {
-    Respond(OneArgument(std::move(result_value)));
+    Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));
   } else {
     VLOG(1) << "update component error: " << (int)error;
-    Respond(OneArgument(std::move(result_value)));
+    Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ void NwAppEnableComponentFunction::OnRegistered() {`
`122`	`122`	`}`
`123`	`123`	`auto result_value = std::make_unique<base::Value>(ret);`
`124`	`124`
`125`		`- Respond(OneArgument(std::move(result_value)));`
	`125`	`+ Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`ExtensionFunction::ResponseAction`
`@@ -138,10 +138,10 @@ void NwAppUpdateComponentFunction::OnUpdated(update_client::Error error) {`
`138`	`138`	`bool ret = (error == update_client::Error::NONE);`
`139`	`139`	`auto result_value = std::make_unique<base::Value>(ret);`
`140`	`140`	`if (ret) {`
`141`		`- Respond(OneArgument(std::move(result_value)));`
	`141`	`+ Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));`
`142`	`142`	`} else {`
`143`	`143`	`VLOG(1) << "update component error: " << (int)error;`
`144`		`- Respond(OneArgument(std::move(result_value)));`
	`144`	`+ Respond(OneArgument(base::Value::FromUniquePtrValue(std::move(result_value))));`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`