Throw Error when url.parse without true is parsed (vercel#1282)

timneutkens · rauchg · commit 40738c6e44ff · 2017-03-01T15:30:07.000-08:00
* Throw Error when url.parse without true is parsed

This is a bit more descriptive when this mistake is made by the user.

* Parse when needed

* Parse querystring if it is not provided
diff --git a/server/index.js b/server/index.js
@@ -1,5 +1,6 @@
 import { resolve, join } from 'path'
-import { parse } from 'url'
+import { parse as parseUrl } from 'url'
+import { parse as parseQs } from 'querystring'
 import fs from 'mz/fs'
 import http, { STATUS_CODES } from 'http'
 import {
@@ -33,12 +34,14 @@ export default class Server {
 
   getRequestHandler () {
     return (req, res, parsedUrl) => {
+      // Parse url if parsedUrl not provided
       if (!parsedUrl) {
-        parsedUrl = parse(req.url, true)
+        parsedUrl = parseUrl(req.url, true)
       }
 
-      if (!parsedUrl.query) {
-        throw new Error('Please provide a parsed url to `handle` as third parameter. See https://github.com/zeit/next.js#custom-server-and-routing for an example.')
+      // Parse the querystring ourselves if the user doesn't handle querystring parsing
+      if (typeof parsedUrl.query === 'string') {
+        parsedUrl.query = parseQs(parsedUrl.query)
       }
 
       return this.run(req, res, parsedUrl)
@@ -222,7 +225,7 @@ export default class Server {
     }
   }
 
-  async render404 (req, res, parsedUrl = parse(req.url, true)) {
+  async render404 (req, res, parsedUrl = parseUrl(req.url, true)) {
     const { pathname, query } = parsedUrl
     res.statusCode = 404
     return this.renderError(null, req, res, pathname, query)
