Fix .json import issue (vercel#944)

arunoda · nkzawa · commit ec2c8c6784aa · 2017-02-01T15:17:15.000+09:00
* Fix .json import error This is a regression we've added by vercel#926 (tree-shaking-support) * Add a test case.
diff --git a/server/build/loaders/emit-file-loader.js b/server/build/loaders/emit-file-loader.js
@@ -16,7 +16,7 @@ module.exports = function (content, sourceMap) {
   }
 
   if (query.transform) {
-    const transformed = query.transform({ content, sourceMap })
+    const transformed = query.transform({ content, sourceMap, interpolatedName })
     return emit(transformed.content, transformed.sourceMap)
   }
 
diff --git a/server/build/webpack.js b/server/build/webpack.js
@@ -149,7 +149,12 @@ export default async function createCompiler (dir, { dev = false, quiet = false
       // By default, our babel config does not transpile ES2015 module syntax because
       // webpack knows how to handle them. (That's how it can do tree-shaking)
       // But Node.js doesn't know how to handle them. So, we have to transpile them here.
-      transform ({ content, sourceMap }) {
+      transform ({ content, sourceMap, interpolatedName }) {
+        // Only handle .js files
+        if (!(/\.js$/.test(interpolatedName))) {
+          return { content, sourceMap }
+        }
+
         const transpiled = babelCore.transform(content, {
           presets: ['es2015'],
           sourceMaps: dev ? 'both' : false,
diff --git a/test/integration/basic/lib/data.json b/test/integration/basic/lib/data.json
@@ -0,0 +1,3 @@
+{
+    "name": "Zeit"
+}
diff --git a/test/integration/basic/pages/json.js b/test/integration/basic/pages/json.js
@@ -0,0 +1,5 @@
+import data from '../lib/data'
+
+export default () => (
+  <div>{data.name}</div>
+)
diff --git a/test/integration/basic/test/rendering.js b/test/integration/basic/test/rendering.js
@@ -61,6 +61,11 @@ export default function ({ app }, suiteName, render) {
       expect($('pre').text().includes(expectedErrorMessage)).toBeTruthy()
     })
 
+    test('allows to import .json files', async () => {
+      const html = await render('/json')
+      expect(html.includes('Zeit')).toBeTruthy()
+    })
+
     test('error', async () => {
       const $ = await get$('/error')
       expect($('pre').text()).toMatch(/This is an expected error/)

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ module.exports = function (content, sourceMap) {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`if (query.transform) {`
`19`		`- const transformed = query.transform({ content, sourceMap })`
	`19`	`+ const transformed = query.transform({ content, sourceMap, interpolatedName })`
`20`	`20`	`return emit(transformed.content, transformed.sourceMap)`
`21`	`21`	`}`
`22`	`22`