Include flow types for Record.get() mirroring immutable-js#1461

leebyron · leebyron · commit a1029bba958d · 2018-05-17T13:57:08.000+02:00
diff --git a/type-definitions/immutable.js.flow b/type-definitions/immutable.js.flow
@@ -1401,7 +1401,9 @@ declare class RecordInstance<T: Object> {
   size: number;
 
   has(key: string): boolean;
-  get<K: $Keys<T>>(key: K, notSetValue: mixed): $ElementType<T, K>;
+
+  get<K: $Keys<T>>(key: K, ..._: []): $ElementType<T, K>;
+  get<K: $Keys<T>, NSV>(key: K, notSetValue: NSV): $ElementType<T, K> | NSV;
 
   hasIn(keyPath: Iterable<mixed>): boolean;
 
diff --git a/type-definitions/tests/record.js b/type-definitions/tests/record.js
@@ -41,6 +41,9 @@ let geoPointExpected2: RecordOf<TGeoPoint> = Point2({});
 const px = origin2.get('x');
 const px2: number = origin2.x;
 // $ExpectError
+const px3: number = origin2.get('x', 'not set value');
+const px4: number | string = origin2.get('x', 'not set value');
+// $ExpectError
 const pz = origin2.get('z');
 // $ExpectError
 const pz2 = origin2.z;
