refactor LitterStatus regarding consultation with Vasile, adding extra error code and Exception Handling by Kevin's user service

Csaba79-coder · Csaba79-coder · commit 9401c546c4a2 · 2023-05-30T16:47:52.000+02:00
diff --git a/src/main/java/com/csaba79coder/littersnap/exception/ControllerExceptionHandler.java b/src/main/java/com/csaba79coder/littersnap/exception/ControllerExceptionHandler.java
@@ -15,6 +15,8 @@
 import static com.csaba79coder.littersnap.value.ErrorCode.LS_001;
 import static com.csaba79coder.littersnap.value.ErrorCode.LS_002;
 import static com.csaba79coder.littersnap.value.ErrorCode.LS_003;
+import static com.csaba79coder.littersnap.value.ErrorCode.LS_004;
+import static com.csaba79coder.littersnap.value.ErrorCode.LS_005;
 
 @ControllerAdvice
 public class ControllerExceptionHandler {
@@ -36,7 +38,12 @@ public ResponseEntity<Object> handleInvalidPasswordOrUsernameException(Validatio
 
     @ExceptionHandler(value = {SendFailedException.class})
     public ResponseEntity<Object> handleSendFailedException(SendFailedException ex) {
-        return new ResponseEntity<>(responseBodyWithMessage(LS_003, ex.getMessage()), HttpStatus.BAD_REQUEST);
+        return new ResponseEntity<>(responseBodyWithMessage(LS_004, ex.getMessage()), HttpStatus.BAD_REQUEST);
+    }
+
+    @ExceptionHandler(value = {IllegalArgumentException.class})
+    public ResponseEntity<Object> handleIllegalArgumentException(IllegalArgumentException ex) {
+        return new ResponseEntity<>(responseBodyWithMessage(LS_005, ex.getMessage()), HttpStatus.INTERNAL_SERVER_ERROR);
     }
 
     private String responseBodyWithMessage(ErrorCode code, String message) {
diff --git a/src/main/java/com/csaba79coder/littersnap/value/ErrorCode.java b/src/main/java/com/csaba79coder/littersnap/value/ErrorCode.java
@@ -2,5 +2,5 @@
 
 public enum ErrorCode {
 
-    LS_001, LS_002, LS_003, LS_004
+    LS_001, LS_002, LS_003, LS_004, LS_005
 }
diff --git a/src/main/java/com/csaba79coder/littersnap/value/LitterStatus.java b/src/main/java/com/csaba79coder/littersnap/value/LitterStatus.java
@@ -1,10 +1,8 @@
 package com.csaba79coder.littersnap.value;
 
 public enum LitterStatus {
-
-    COLLECTED,
-    REMOVED,
     REPORTED,
-    UNREPORTED,
+    COMPLETED,
+    PROCESSING,
     NOT_FOUND
 }

Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,5 @@`
`2`	`2`
`3`	`3`	`public enum ErrorCode {`
`4`	`4`
`5`		`- LS_001, LS_002, LS_003, LS_004`
	`5`	`+ LS_001, LS_002, LS_003, LS_004, LS_005`
`6`	`6`	`}`