Reduce duplicate code

joni2back · joni2back · commit 61ea4ca71b8a · 2014-01-23T09:54:15.000-02:00
do not duplicate the array walk, just check in the same for both cases
diff --git a/functions/array/in_array.js b/functions/array/in_array.js
@@ -2,6 +2,7 @@ function in_array(needle, haystack, argStrict) {
   //  discuss at: http://phpjs.org/functions/in_array/
   // original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
   // improved by: vlado houba
+  // improved by: Jonas Sciangula Street (Joni2Back)
   //    input by: Billy
   // bugfixed by: Brett Zamir (http://brett-zamir.me)
   //   example 1: in_array('van', ['Kevin', 'van', 'Zonneveld']);
@@ -17,20 +18,10 @@ function in_array(needle, haystack, argStrict) {
 
   var key = '',
     strict = !! argStrict;
-
-  if (strict) {
     for (key in haystack) {
-      if (haystack[key] === needle) {
+      if ((strict && haystack[key] === needle) || (!strict && haystack[key] == needle)) {
         return true;
       }
-    }
-  } else {
-    for (key in haystack) {
-      if (haystack[key] == needle) {
-        return true;
-      }
-    }
   }
-
   return false;
-}
+}
