minor symfony#39975 [Serializer] Fix tests wrongly marked as incomplete (chalasr)

nicolas-grekas · nicolas-grekas · commit ffdc46c86b5c · 2021-01-26T21:39:55.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix tests wrongly marked as incomplete | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - symfony#30907 has been merged meanwhile. Commits ------- e632302 [Serializer] Fix tests marked as incomplete
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/IgnoredAttributesTestTrait.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/IgnoredAttributesTestTrait.php
@@ -38,8 +38,6 @@ public function testIgnoredAttributesNormalize()
             $normalizer->normalize($objectOuter, null, $context)
         );
 
-        $this->markTestIncomplete('AbstractObjectNormalizer::getAttributes caches attributes by class instead of by class+context, reusing the normalizer with different config therefore fails. This is being fixed in https://github.com/symfony/symfony/pull/30907');
-
         $context = ['ignored_attributes' => ['foo', 'inner']];
         $this->assertEquals(
             [

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,6 @@ public function testIgnoredAttributesNormalize()`
`38`	`38`	`$normalizer->normalize($objectOuter, null, $context)`
`39`	`39`	`);`
`40`	`40`
`41`		`- $this->markTestIncomplete('AbstractObjectNormalizer::getAttributes caches attributes by class instead of by class+context, reusing the normalizer with different config therefore fails. This is being fixed in https://github.com/symfony/symfony/pull/30907');`
`42`		`-`
`43`	`41`	`$context = ['ignored_attributes' => ['foo', 'inner']];`
`44`	`42`	`$this->assertEquals(`
`45`	`43`	`[`