Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innapropriate application of urldecoding #380

Closed
mitskirm opened this issue Aug 15, 2023 · 2 comments
Closed

Innapropriate application of urldecoding #380

mitskirm opened this issue Aug 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mitskirm
Copy link

Type: Bug

Create 2 files (both onle-liners):

bug.php containing: <?php require 'bug%%31.php';
bug%%31.php containing: <?php throw new Error();

Debugging with break on exception fails by trying to open the wrong file "bug%1.php"

It should open the actual file "bug%%31.php"

Extension version: 1.37.13534
VS Code version: Code 1.81.0 (6445d93c81ebe42c4cbd7a60712e0b17d9463e97, 2023-08-02T12:37:13.485Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 15.88GB (6.66GB free)
Process Argv --crash-reporter-id adf79977-8c83-4303-918e-a7dfc5f31bf1
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263cf:30792227
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
282f8724:30602487
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofa:30804715
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv1:30812748

@jakubmisek jakubmisek added the bug Something isn't working label Aug 15, 2023
@jakubmisek jakubmisek assigned Miloslav and jakubmisek and unassigned Miloslav Aug 27, 2023
@jakubmisek
Copy link
Member

Thank you for reporting that! Will be fixed in the next update or pre-release.

@jakubmisek
Copy link
Member

Fixed in the latest update 1.38, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants