Record.__eq__: replace exact type comparisons with isinstance.

Benjamin Moody · Benjamin Moody · commit 9d77075ebff0 · 2022-03-11T13:24:21.000-05:00
When comparing the attributes of two records, if a value is an
instance of a class derived from 'np.ndarray' or a class derived from
'list', it should be treated the same way as an 'np.ndarray' or a
'list'.  Note that there currently are no such classes defined or used
by this package.

Note also that in any case, the respective types of the two attributes
must be equal in order for the values to be considered equal.
diff --git a/wfdb/io/record.py b/wfdb/io/record.py
@@ -625,11 +625,11 @@ def __eq__(self, other, verbose=False):
                     print('Mismatch in attribute: %s' % k, v1, v2)
                 return False
 
-            if type(v1) == np.ndarray:
+            if isinstance(v1, np.ndarray):
                 # Necessary for nans
                 np.testing.assert_array_equal(v1, v2)
-            elif (type(v1) == list and len(v1) == len(v2)
-                  and all(type(e) == np.ndarray for e in v1)):
+            elif (isinstance(v1, list) and len(v1) == len(v2)
+                  and all(isinstance(e, np.ndarray) for e in v1)):
                 for (e1, e2) in zip(v1, v2):
                     np.testing.assert_array_equal(e1, e2)
             else:
