Skip to content

Commit d7adb78

Browse files
committed
Merge branch 'hotfix/update-webpack-deprecations'
2 parents 20115ed + 2ae17ad commit d7adb78

File tree

4 files changed

+40
-29
lines changed

4 files changed

+40
-29
lines changed

template/app/src/renderer/vuex/store.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ export default new Vuex.Store({
1111
actions,
1212
getters,
1313
modules,
14-
strict: true
14+
strict: process.env.NODE_ENV !== 'production'
1515
})

template/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@
149149
"vue-loader": "^10.0.2",
150150
"vue-style-loader": "^1.0.0",
151151
"vue-template-compiler": "^2.1.10",
152-
"webpack": "^2.2.0",
153-
"webpack-dev-server": "^2.2.0"
152+
"webpack": "^2.2.1",
153+
"webpack-dev-server": "^2.3.0"
154154
},
155155
"dependencies": {}
156156
}

template/test/unit/karma.conf.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@ delete webpackConfig.externals
2222
delete webpackConfig.output.libraryTarget
2323

2424
// only apply babel for test files when using isparta
25-
webpackConfig.module.rules.some(loader => {
26-
if (loader.loader === 'babel-loader') {
27-
loader.include.push(path.resolve(projectRoot, '../test/unit'))
25+
webpackConfig.module.rules.some(rule => {
26+
if (rule.use === 'babel-loader') {
27+
rule.include.push(path.resolve(projectRoot, '../test/unit'))
2828
return true
2929
}
3030
})
3131

3232
// apply vue option to apply isparta-loader on js
3333
webpackConfig.module.rules
34-
.find(({ loader }) => loader === 'vue-loader').options.loaders.js = 'babel-loader'
34+
.find(rule => rule.use.loader === 'vue-loader').use.options.loaders.js = 'babel-loader'
3535

3636
module.exports = config => {
3737
config.set({

template/webpack.renderer.config.js

Lines changed: 33 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin')
1212

1313
let rendererConfig = {
1414
devtool: '#eval-source-map',
15+
devServer: { overlay: true },
1516
entry: {
1617
renderer: path.join(__dirname, 'app/src/renderer/main.js')
1718
},
@@ -20,53 +21,59 @@ let rendererConfig = {
2021
rules: [
2122
{
2223
test: /\.css$/,
23-
loader: ExtractTextPlugin.extract({
24-
fallbackLoader: 'style-loader',
25-
loader: 'css-loader'
24+
use: ExtractTextPlugin.extract({
25+
fallback: 'style-loader',
26+
use: 'css-loader'
2627
})
2728
},
2829
{
2930
test: /\.html$/,
30-
loader: 'vue-html-loader'
31+
use: 'vue-html-loader'
3132
},
3233
{
3334
test: /\.js$/,
34-
loader: 'babel-loader',
35+
use: 'babel-loader',
3536
include: [ path.resolve(__dirname, 'app/src/renderer') ],
3637
exclude: /node_modules/
3738
},
3839
{
3940
test: /\.json$/,
40-
loader: 'json-loader'
41+
use: 'json-loader'
4142
},
4243
{
4344
test: /\.node$/,
44-
loader: 'node-loader'
45+
use: 'node-loader'
4546
},
4647
{
4748
test: /\.vue$/,
48-
loader: 'vue-loader',
49-
options: {
50-
loaders: {
51-
sass: 'vue-style-loader!css-loader!sass-loader?indentedSyntax=1',
52-
scss: 'vue-style-loader!css-loader!sass-loader'
49+
use: {
50+
loader: 'vue-loader',
51+
options: {
52+
loaders: {
53+
sass: 'vue-style-loader!css-loader!sass-loader?indentedSyntax=1',
54+
scss: 'vue-style-loader!css-loader!sass-loader'
55+
}
5356
}
5457
}
5558
},
5659
{
5760
test: /\.(png|jpe?g|gif|svg)(\?.*)?$/,
58-
loader: 'url-loader',
59-
query: {
60-
limit: 10000,
61-
name: 'imgs/[name].[ext]'
61+
use: {
62+
loader: 'url-loader',
63+
query: {
64+
limit: 10000,
65+
name: 'imgs/[name].[ext]'
66+
}
6267
}
6368
},
6469
{
6570
test: /\.(woff2?|eot|ttf|otf)(\?.*)?$/,
66-
loader: 'url-loader',
67-
query: {
68-
limit: 10000,
69-
name: 'fonts/[name].[ext]'
71+
use: {
72+
loader: 'url-loader',
73+
query: {
74+
limit: 10000,
75+
name: 'fonts/[name].[ext]'
76+
}
7077
}
7178
}
7279
]
@@ -110,10 +117,14 @@ if (process.env.NODE_ENV !== 'production') {
110117
rendererConfig.module.rules.push(
111118
{
112119
test: /\.(js|vue)$/,
113-
loader: 'eslint-loader',
114120
enforce: 'pre',
115121
exclude: /node_modules/,
116-
options: { formatter: require('eslint-friendly-formatter') }
122+
use: {
123+
loader: 'eslint-loader',
124+
options: {
125+
formatter: require('eslint-friendly-formatter')
126+
}
127+
}
117128
}
118129
)
119130
}

0 commit comments

Comments
 (0)