Fix type inference for ALLOWED_TYPES.

Benjamin Moody · Benjamin Moody · commit 83cdfaa795d3 · 2023-03-30T15:36:19.000-04:00
When using mypy to check the package, it will attempt to infer types
that are not specified.

Currently, mypy is able to understand that constructing a dict from a
Sequence[Tuple[X, Y]] yields a Dict[X, Y], but if we use lists instead
of tuples, mypy doesn't understand and seems to think the result is a
Dict[X, X].

This is probably a bug in mypy, but in any case, using tuples here
rather than lists is more idiomatic and doesn't affect the behavior of
the code.
diff --git a/wfdb/io/record.py b/wfdb/io/record.py
@@ -1661,7 +1661,7 @@ def multi_to_single(self, physical, return_res=64, expanded=False):
 # this library
 ALLOWED_TYPES = dict(
     [
-        [index, _header.FIELD_SPECS.loc[index, "allowed_types"]]
+        (index, _header.FIELD_SPECS.loc[index, "allowed_types"])
         for index in _header.FIELD_SPECS.index
     ]
 )

Original file line number	Diff line number	Diff line change
`@@ -1661,7 +1661,7 @@ def multi_to_single(self, physical, return_res=64, expanded=False):`
`1661`	`1661`	`# this library`
`1662`	`1662`	`ALLOWED_TYPES = dict(`
`1663`	`1663`	`[`
`1664`		`- [index, _header.FIELD_SPECS.loc[index, "allowed_types"]]`
	`1664`	`+ (index, _header.FIELD_SPECS.loc[index, "allowed_types"])`
`1665`	`1665`	`for index in _header.FIELD_SPECS.index`
`1666`	`1666`	`]`
`1667`	`1667`	`)`