Skip to content

Commit 041d59c

Browse files
jkeiserjkeiser
committed
Create acceptance_tests, all_tests, etc. make targets
And use them for mingw build and test
1 parent a405173 commit 041d59c

File tree

11 files changed

+85
-102
lines changed

11 files changed

+85
-102
lines changed

‎.appveyor.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,24 @@ environment:
1313

1414
matrix:
1515
- job_name: VS2019
16-
CMAKE_ARGS: -A %Platform%
16+
CMAKE_ARGS: -A %Platform%
1717
- job_name: VS2019ARM
1818
CMAKE_ARGS: -A ARM64 -DCMAKE_CROSSCOMPILING=1 -D SIMDJSON_GOOGLE_BENCHMARKS=OFF # Does Google Benchmark builds under VS ARM?
1919
- job_name: VS2017 (Static, No Threads)
2020
image: Visual Studio 2017
21-
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
21+
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
2222
CTEST_ARGS: -LE explicitonly
2323
- job_name: VS2019 (Win32)
2424
platform: Win32
25-
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_ENABLE_THREADS=ON # This should be the default. Testing anyway.
26-
CTEST_ARGS: -E "checkperf|ondemand_basictests"
25+
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_ENABLE_THREADS=ON # This should be the default. Testing anyway.
26+
CTEST_ARGS: -LE explicitonly
2727
- job_name: VS2019 (Win32, No Exceptions)
2828
platform: Win32
29-
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_ENABLE_THREADS=ON -DSIMDJSON_EXCEPTIONS=OFF
30-
CTEST_ARGS: -E "checkperf|ondemand_basictests"
29+
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_ENABLE_THREADS=ON -DSIMDJSON_EXCEPTIONS=OFF
30+
CTEST_ARGS: -LE explicitonly
3131
- job_name: VS2015
3232
image: Visual Studio 2015
33-
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
33+
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
3434
CTEST_ARGS: -LE explicitonly
3535

3636
build_script:

‎.github/workflows/mingw-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,5 @@ jobs:
6161
mkdir build32
6262
cd build32
6363
cmake -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_COMPETITION=OFF -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DSIMDJSON_ENABLE_THREADS=OFF ..
64-
cmake --build . --target parse_many_test jsoncheck basictests ondemand_basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
65-
ctest -R "(parse_many_test|jsoncheck|basictests|stringparsingcheck|numberparsingcheck|errortests|integer_tests|pointercheck)" --output-on-failure
64+
cmake --build . --target acceptance_tests --verbose
65+
ctest -L acceptance -LE no_mingw --output-on-failure

‎.github/workflows/mingw64-ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ jobs:
6161
mkdir build64
6262
cd build64
6363
cmake -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_COMPETITION=OFF -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DSIMDJSON_ENABLE_THREADS=OFF ..
64-
cmake --build . --target parse_many_test jsoncheck basictests ondemand_basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
65-
ctest -R "(parse_many_test|jsoncheck|basictests|stringparsingcheck|numberparsingcheck|errortests|integer_tests|pointercheck)" --output-on-failure
64+
cmake --build . --target acceptance_tests --verbose
65+
ctest -L acceptance -LE no_mingw --output-on-failure
6666
cd ..
6767
mkdir build64debug
6868
cd build64debug
6969
cmake -DCMAKE_BUILD_TYPE=Debug -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_COMPETITION=OFF -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DSIMDJSON_ENABLE_THREADS=OFF ..
70-
cmake --build . --target parse_many_test jsoncheck basictests ondemand_basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
71-
ctest -R "(parse_many_test|jsoncheck|basictests|stringparsingcheck|numberparsingcheck|errortests|integer_tests|pointercheck)" --output-on-failure
70+
cmake --build . --target acceptance_tests --verbose
71+
ctest -L acceptance -LE no_mingw --output-on-failure

‎cmake/add_compile_only_test.cmake

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
function(add_compile_only_test TEST_NAME)
2+
add_test(
3+
NAME ${TEST_NAME}
4+
COMMAND ${CMAKE_COMMAND} --build . --target ${TEST_NAME} --config $<CONFIGURATION>
5+
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
6+
)
7+
set_target_properties(${TEST_NAME} PROPERTIES EXCLUDE_FROM_ALL TRUE EXCLUDE_FROM_DEFAULT_BUILD TRUE)
8+
endfunction()

‎cmake/add_cpp_test.cmake

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
# SOURCES defaults to testname.cpp if not specified.
44
function(add_cpp_test TEST_NAME)
55
# Parse arguments
6-
cmake_parse_arguments(PARSE_ARGV 1 ARGS "COMPILE_ONLY;LIBRARY;WILL_FAIL" "" "SOURCES;LABELS")
6+
cmake_parse_arguments(PARSE_ARGV 1 ARGS "COMPILE_ONLY;LIBRARY;WILL_FAIL" "" "SOURCES;LABELS;DEPENDENCY_OF")
77
if (NOT ARGS_SOURCES)
88
list(APPEND ARGS_SOURCES ${TEST_NAME}.cpp)
99
endif()
1010
if (ARGS_COMPILE_ONLY)
11-
list(APPEND ${ARGS_LABELS} compile)
11+
list(APPEND ${ARGS_LABELS} compile_only)
1212
endif()
1313

1414
# Add the compile target
@@ -28,22 +28,29 @@ function(add_cpp_test TEST_NAME)
2828
set_target_properties(${TEST_NAME} PROPERTIES EXCLUDE_FROM_ALL TRUE EXCLUDE_FROM_DEFAULT_BUILD TRUE)
2929
else()
3030
add_test(${TEST_NAME} ${TEST_NAME})
31+
32+
# Add to <label>_tests make targets
33+
foreach(label ${ARGS_LABELS})
34+
list(APPEND ARGS_DEPENDENCY_OF ${label})
35+
endforeach(label ${ARGS_LABELS})
3136
endif()
3237

38+
# Add to test labels
3339
if (ARGS_LABELS)
3440
set_property(TEST ${TEST_NAME} APPEND PROPERTY LABELS ${ARGS_LABELS})
3541
endif()
3642

43+
# Add as a dependency of given targets
44+
foreach(dependency_of ${ARGS_DEPENDENCY_OF})
45+
if (NOT TARGET ${dependency_of}_tests)
46+
add_custom_target(${dependency_of}_tests)
47+
add_dependencies(all_tests ${dependency_of}_tests)
48+
endif(NOT TARGET ${dependency_of}_tests)
49+
add_dependencies(${dependency_of}_tests ${TEST_NAME})
50+
endforeach(dependency_of ${ARGS_DEPENDENCY_OF})
51+
52+
# If it will fail, mark the test as such
3753
if (ARGS_WILL_FAIL)
3854
set_property(TEST ${TEST_NAME} PROPERTY WILL_FAIL TRUE)
3955
endif()
4056
endfunction()
41-
42-
function(add_compile_only_test TEST_NAME)
43-
add_test(
44-
NAME ${TEST_NAME}
45-
COMMAND ${CMAKE_COMMAND} --build . --target ${TEST_NAME} --config $<CONFIGURATION>
46-
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
47-
)
48-
set_target_properties(${TEST_NAME} PROPERTIES EXCLUDE_FROM_ALL TRUE EXCLUDE_FROM_DEFAULT_BUILD TRUE)
49-
endfunction()

‎examples/quickstart/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,15 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
5151
add_quickstart_test(quickstart quickstart.cpp)
5252
add_quickstart_test(quickstart11 quickstart.cpp c++11)
5353
add_quickstart_test(quickstart14 quickstart.cpp c++14)
54-
set_property( TEST quickstart quickstart11 APPEND PROPERTY LABELS acceptance compiletests )
54+
set_property( TEST quickstart quickstart11 APPEND PROPERTY LABELS acceptance compiletests no_mingw)
5555
endif()
5656

5757
add_quickstart_test(quickstart_noexceptions quickstart_noexceptions.cpp "" true)
5858
add_quickstart_test(quickstart_noexceptions11 quickstart_noexceptions.cpp c++11 true)
59-
set_property( TEST quickstart_noexceptions APPEND PROPERTY LABELS acceptance compile )
59+
set_property( TEST quickstart_noexceptions APPEND PROPERTY LABELS acceptance compile no_mingw)
6060

6161
add_quickstart_test(quickstart2_noexceptions quickstart2_noexceptions.cpp "" true)
6262
add_quickstart_test(quickstart2_noexceptions11 quickstart2_noexceptions.cpp c++11 true)
63-
set_property( TEST quickstart2_noexceptions APPEND PROPERTY LABELS acceptance compile )
63+
set_property( TEST quickstart2_noexceptions APPEND PROPERTY LABELS acceptance compile no_mingw)
6464

6565
endif()

‎singleheader/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
include(${PROJECT_SOURCE_DIR}/cmake/add_cpp_test.cmake)
2-
31
#
42
# Amalgamation
53
#
@@ -117,6 +115,8 @@ target_link_libraries(simdjson-singleheader-source INTERFACE simdjson-singlehead
117115
#
118116
#
119117

118+
include(${PROJECT_SOURCE_DIR}/cmake/add_compile_only_test.cmake)
119+
120120
#
121121
# Test the generated simdjson.cpp/simdjson.h using the generated amalgamate_demo.cpp
122122
#

‎src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ if(NOT MSVC)
101101
# Please do not delete the following, our users want version numbers. See
102102
# https://github.com/simdjson/simdjson/issues/1014
103103
# https://github.com/simdjson/simdjson/issues/52
104-
###########
104+
###########
105105
set_target_properties(simdjson PROPERTIES VERSION ${SIMDJSON_LIB_VERSION} SOVERSION ${SIMDJSON_LIB_SOVERSION})
106106
##########
107107
# End of the do-not-delete message.

‎tests/CMakeLists.txt

Lines changed: 28 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,10 @@
1-
# Helper so we don't have to repeat ourselves so much
2-
# Usage: add_cpp_test(testname [COMPILE_ONLY] [SOURCES a.cpp b.cpp ...] [LABELS acceptance per_implementation ...])
3-
# SOURCES defaults to testname.cpp if not specified.
4-
function(add_cpp_test TEST_NAME)
5-
# Parse arguments
6-
cmake_parse_arguments(PARSE_ARGV 1 ARGS "COMPILE_ONLY;WILL_FAIL" "" "SOURCES;LABELS")
7-
if (NOT ARGS_SOURCES)
8-
list(APPEND ARGS_SOURCES ${TEST_NAME}.cpp)
9-
endif()
10-
if (COMPILE_ONLY)
11-
list(APPEND ${ARGS_LABELS} compile)
12-
endif()
13-
14-
# Add executable
15-
add_executable(${TEST_NAME} ${ARGS_SOURCES})
16-
17-
# Add test
18-
if (ARGS_COMPILE_ONLY)
19-
add_test(
20-
NAME ${TEST_NAME}
21-
COMMAND ${CMAKE_COMMAND} --build . --target ${TEST_NAME} --config $<CONFIGURATION>
22-
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
23-
)
24-
set_target_properties(${TEST_NAME} PROPERTIES EXCLUDE_FROM_ALL TRUE EXCLUDE_FROM_DEFAULT_BUILD TRUE)
25-
else()
26-
add_test(${TEST_NAME} ${TEST_NAME})
27-
endif()
28-
29-
if (ARGS_LABELS)
30-
set_property(TEST ${TEST_NAME} APPEND PROPERTY LABELS ${ARGS_LABELS})
31-
endif()
32-
33-
if (ARGS_WILL_FAIL)
34-
set_property(TEST ${TEST_NAME} PROPERTY WILL_FAIL TRUE)
35-
endif()
36-
endfunction()
37-
381
# Most tests need test data, and many need windows headers.
392
link_libraries(simdjson-internal-flags test-data simdjson-windows-headers)
40-
413
include(${PROJECT_SOURCE_DIR}/cmake/add_cpp_test.cmake)
424

5+
# add_cpp_tests will add dependencies to this
6+
add_custom_target(all_tests)
7+
438
add_subdirectory(ondemand)
449

4510
#
@@ -54,20 +19,21 @@ target_compile_definitions(stringparsingcheck PRIVATE NOMINMAX)
5419

5520
# All remaining tests link with simdjson proper
5621
link_libraries(simdjson)
57-
add_cpp_test(random_string_number_tests LABELS acceptance per_implementation)
58-
add_cpp_test(basictests LABELS acceptance per_implementation)
59-
add_cpp_test(minify_tests LABELS acceptance per_implementation)
60-
add_cpp_test(document_stream_tests LABELS acceptance per_implementation)
61-
add_cpp_test(document_tests LABELS acceptance per_implementation)
62-
add_cpp_test(errortests LABELS acceptance per_implementation)
63-
add_cpp_test(integer_tests LABELS acceptance per_implementation)
64-
add_cpp_test(jsoncheck LABELS acceptance per_implementation)
65-
add_cpp_test(minefieldcheck LABELS acceptance per_implementation)
66-
add_cpp_test(parse_many_test LABELS acceptance per_implementation)
67-
add_cpp_test(pointercheck LABELS acceptance per_implementation) # https://tools.ietf.org/html/rfc6901
68-
add_cpp_test(extracting_values_example LABELS acceptance per_implementation)
69-
add_cpp_test(unicode_tests LABELS acceptance per_implementation)
70-
add_cpp_test(padded_string_tests)
22+
add_cpp_test(random_string_number_tests LABELS dom acceptance per_implementation no_mingw)
23+
add_cpp_test(basictests LABELS dom acceptance per_implementation)
24+
add_cpp_test(document_stream_tests LABELS dom acceptance per_implementation no_mingw)
25+
add_cpp_test(document_tests LABELS dom acceptance per_implementation no_mingw)
26+
add_cpp_test(errortests LABELS dom acceptance per_implementation)
27+
add_cpp_test(extracting_values_example LABELS dom acceptance per_implementation no_mingw)
28+
add_cpp_test(integer_tests LABELS dom acceptance per_implementation)
29+
add_cpp_test(jsoncheck LABELS dom acceptance per_implementation)
30+
add_cpp_test(minefieldcheck LABELS dom acceptance per_implementation no_mingw)
31+
add_cpp_test(parse_many_test LABELS dom acceptance per_implementation)
32+
add_cpp_test(pointercheck LABELS dom acceptance per_implementation) # https://tools.ietf.org/html/rfc6901
33+
add_cpp_test(unicode_tests LABELS dom acceptance per_implementation no_mingw)
34+
35+
add_cpp_test(minify_tests LABELS other acceptance per_implementation no_mingw)
36+
add_cpp_test(padded_string_tests LABELS other acceptance no_mingw)
7137

7238
find_program(BASH bash)
7339

@@ -94,11 +60,13 @@ if (BASH AND (NOT WIN32) AND SIMDJSON_BASH AND (TARGET json2json)) # The scripts
9460
if ((SIMDJSON_COMPETITION) AND (!SIMDJSON_SANITIZE))
9561
# It looks like RapidJSON does not pass the sanitizer under some conditions (Clang 10)
9662
add_executable(allparserscheckfile allparserscheckfile.cpp)
63+
add_dependencies(competition_tests allparserscheckfile)
64+
add_dependencies(per_implementation_tests allparserscheckfile)
9765
target_link_libraries(allparserscheckfile PRIVATE competition-all)
9866

9967
add_test(issue150 ${BASH} ${CMAKE_CURRENT_SOURCE_DIR}/issue150.sh)
10068
set_property(TEST issue150 APPEND PROPERTY DEPENDS allparserscheckfile)
101-
set_property(TEST issue150 APPEND PROPERTY LABELS per_implementation)
69+
set_property(TEST issue150 APPEND PROPERTY LABELS per_implementation competition)
10270
endif()
10371

10472
#
@@ -107,10 +75,10 @@ if (BASH AND (NOT WIN32) AND SIMDJSON_BASH AND (TARGET json2json)) # The scripts
10775

10876
# This tests validates that the implementation is what we think it is if we get passed
10977
# SIMDJSON_FORCE_IMPLEMENTATION, so we know we're testing what we think we're testing
110-
add_cpp_test(checkimplementation LABELS per_implementation)
78+
add_cpp_test(checkimplementation LABELS other per_implementation)
11179

11280
add_test(NAME json2json COMMAND $<TARGET_FILE:json2json> ${EXAMPLE_JSON})
113-
set_property(TEST json2json APPEND PROPERTY LABELS acceptance per_implementation)
81+
set_property(TEST json2json APPEND PROPERTY LABELS acceptance per_implementation no_mingw)
11482

11583
#
11684
# SIMDJSON_FORCE_IMPLEMENTATION tests: run json2json with SIMDJSON
@@ -141,18 +109,18 @@ endif()
141109
# Don't add the tests if we're on VS2017 or older; they don't succeed.
142110
if(NOT (MSVC AND MSVC_VERSION LESS 1920))
143111
if(SIMDJSON_EXCEPTIONS)
144-
add_cpp_test(readme_examples COMPILE_ONLY LABELS acceptance)
145-
add_cpp_test(readme_examples11 COMPILE_ONLY LABELS acceptance SOURCES readme_examples.cpp)
112+
add_cpp_test(readme_examples COMPILE_ONLY LABELS acceptance no_mingw)
113+
add_cpp_test(readme_examples11 COMPILE_ONLY LABELS acceptance no_mingw SOURCES readme_examples.cpp)
146114
set_target_properties(readme_examples11 PROPERTIES CXX_STANDARD 11 CXX_STANDARD_REQUIRED ON CXX_EXTENSIONS OFF)
147115
endif()
148116

149-
add_cpp_test(readme_examples_noexceptions COMPILE_ONLY LABELS acceptance)
117+
add_cpp_test(readme_examples_noexceptions COMPILE_ONLY LABELS acceptance no_mingw)
150118

151-
add_cpp_test(readme_examples_noexceptions11 COMPILE_ONLY LABELS acceptance SOURCES readme_examples_noexceptions.cpp)
119+
add_cpp_test(readme_examples_noexceptions11 COMPILE_ONLY LABELS acceptance no_mingw SOURCES readme_examples_noexceptions.cpp)
152120
set_target_properties(readme_examples_noexceptions11 PROPERTIES CXX_STANDARD 11 CXX_STANDARD_REQUIRED ON CXX_EXTENSIONS OFF)
153121

154122
# Compile tests that *should fail*
155-
add_cpp_test(readme_examples_will_fail_with_exceptions_off WILL_FAIL COMPILE_ONLY LABELS acceptance SOURCES readme_examples.cpp)
123+
add_cpp_test(readme_examples_will_fail_with_exceptions_off WILL_FAIL COMPILE_ONLY LABELS acceptance no_mingw SOURCES readme_examples.cpp)
156124
target_compile_definitions(readme_examples_will_fail_with_exceptions_off PRIVATE SIMDJSON_EXCEPTIONS=0)
157125
endif()
158126

‎tests/compilation_failure_tests/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
# adds a compilation test. Two targets are created, one expected to
99
# succeed compilation and one that is expected to fail.
1010
function(add_dual_compile_test TEST_NAME)
11-
add_cpp_test(${TEST_NAME}_should_compile SOURCES ${TEST_NAME}.cpp COMPILE_ONLY)
12-
add_cpp_test(${TEST_NAME}_should_not_compile SOURCES ${TEST_NAME}.cpp COMPILE_ONLY WILL_FAIL LABELS acceptance)
11+
add_cpp_test(${TEST_NAME}_should_compile SOURCES ${TEST_NAME}.cpp COMPILE_ONLY LABELS no_mingw)
12+
add_cpp_test(${TEST_NAME}_should_not_compile SOURCES ${TEST_NAME}.cpp COMPILE_ONLY WILL_FAIL LABELS acceptance no_mingw)
1313
target_compile_definitions(${TEST_NAME}_should_not_compile PRIVATE COMPILATION_TEST_USE_FAILING_CODE=1)
1414
endfunction(add_dual_compile_test)
1515

‎tests/ondemand/CMakeLists.txt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@
22
link_libraries(simdjson)
33
include_directories(..)
44

5-
add_cpp_test(ondemand_active_tests LABELS acceptance per_implementation ondemand)
6-
add_cpp_test(ondemand_compilation_tests LABELS acceptance per_implementation ondemand)
7-
add_cpp_test(ondemand_dom_api_tests LABELS acceptance per_implementation ondemand)
8-
add_cpp_test(ondemand_error_tests LABELS acceptance per_implementation ondemand)
9-
add_cpp_test(ondemand_key_string_tests LABELS acceptance per_implementation ondemand)
10-
add_cpp_test(ondemand_number_tests LABELS acceptance per_implementation ondemand)
11-
add_cpp_test(ondemand_ordering_tests LABELS acceptance per_implementation ondemand)
12-
add_cpp_test(ondemand_parse_api_tests LABELS acceptance per_implementation ondemand)
13-
add_cpp_test(ondemand_twitter_tests LABELS acceptance per_implementation ondemand)
5+
add_cpp_test(ondemand_active_tests LABELS ondemand acceptance per_implementation)
6+
add_cpp_test(ondemand_compilation_tests LABELS ondemand acceptance per_implementation)
7+
add_cpp_test(ondemand_dom_api_tests LABELS ondemand acceptance per_implementation)
8+
add_cpp_test(ondemand_error_tests LABELS ondemand acceptance per_implementation)
9+
add_cpp_test(ondemand_key_string_tests LABELS ondemand acceptance per_implementation)
10+
add_cpp_test(ondemand_number_tests LABELS ondemand acceptance per_implementation)
11+
add_cpp_test(ondemand_ordering_tests LABELS ondemand acceptance per_implementation)
12+
add_cpp_test(ondemand_parse_api_tests LABELS ondemand acceptance per_implementation)
13+
add_cpp_test(ondemand_twitter_tests LABELS ondemand acceptance per_implementation)
1414

1515
if(HAVE_POSIX_FORK AND HAVE_POSIX_WAIT) # assert tests use fork and wait, which aren't on MSVC
16-
add_cpp_test(ondemand_assert_out_of_order_values LABELS per_implementation explicitonly assert ondemand)
16+
add_cpp_test(ondemand_assert_out_of_order_values LABELS assert per_implementation explicitonly ondemand)
1717
endif()
1818

1919
# Copy the simdjson dll into the tests directory

0 commit comments

Comments
 (0)