Using decimal notation.

lemire · lemire · commit 146191d791d0 · 2020-11-03T22:09:42.000-05:00
diff --git a/include/simdjson/generic/numberparsing.h b/include/simdjson/generic/numberparsing.h
@@ -294,7 +294,7 @@ static bool parse_float_fallback(const uint8_t *ptr, double *outDouble) {
   *outDouble = simdjson::internal::from_chars((const char *)ptr);
   // We do not accept infinite values. Yes, there is a std::isfinite function, but
   // it appears to be broken in legacy libc++.
-  if ((*outDouble > 0x1.fffffffffffffp+1023) || (*outDouble < -0x1.fffffffffffffp+1023)) {
+  if ((*outDouble > 1.7976931348623157e308) || (*outDouble < -1.7976931348623157e308)) {
     return false;
   }
   return true;

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ static bool parse_float_fallback(const uint8_t ptr, double outDouble) {`
`294`	`294`	`outDouble = simdjson::internal::from_chars((const char )ptr);`
`295`	`295`	`// We do not accept infinite values. Yes, there is a std::isfinite function, but`
`296`	`296`	`// it appears to be broken in legacy libc++.`
`297`		`- if ((outDouble > 0x1.fffffffffffffp+1023) \|\| (outDouble < -0x1.fffffffffffffp+1023)) {`
	`297`	`+ if ((outDouble > 1.7976931348623157e308) \|\| (outDouble < -1.7976931348623157e308)) {`
`298`	`298`	`return false;`
`299`	`299`	`}`
`300`	`300`	`return true;`