Fix bug document.get_xxx()

jkeiser · jkeiser · commit 6be9f48fc0e8 · 2020-09-17T09:47:31.000-07:00
diff --git a/include/simdjson/generic/ondemand/document-inl.h b/include/simdjson/generic/ondemand/document-inl.h
@@ -30,7 +30,7 @@ simdjson_really_inline value document::as_value() noexcept {
 template<typename T>
 simdjson_result<T> document::consume_if_success(simdjson_result<T> &&result) noexcept {
   if (result.error()) { json = nullptr; }
-  return result.second;
+  return std::forward<simdjson_result<T>>(result);
 }
 
 simdjson_really_inline simdjson_result<array> document::get_array() & noexcept {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ simdjson_really_inline value document::as_value() noexcept {`
`30`	`30`	`template<typename T>`
`31`	`31`	`simdjson_result<T> document::consume_if_success(simdjson_result<T> &&result) noexcept {`
`32`	`32`	`if (result.error()) { json = nullptr; }`
`33`		`- return result.second;`
	`33`	`+ return std::forward<simdjson_result<T>>(result);`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`simdjson_really_inline simdjson_result<array> document::get_array() & noexcept {`