Skip to content

Commit 73e27bd

Browse files
jkeiserjkeiser
authored
Merge pull request simdjson#852 from furkanusta/cmake-flags
CMake: Separate public and private compilation flags
2 parents f93dbe5 + 064eb0b commit 73e27bd

File tree

7 files changed

+21
-18
lines changed

7 files changed

+21
-18
lines changed

‎benchmark/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
include_directories( . linux )
2-
link_libraries(simdjson simdjson-flags simdjson-windows-headers)
2+
link_libraries(simdjson simdjson-windows-headers)
33
# add_executable(benchfeatures benchfeatures.cpp) # doesn't presently compile at all
44
add_executable(get_corpus_benchmark get_corpus_benchmark.cpp)
55
add_executable(perfdiff perfdiff.cpp)

‎fuzz/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ if(ENABLE_FUZZING)
4040
else ()
4141
target_link_libraries(simdjson-fuzzer INTERFACE simdjson)
4242
endif ()
43-
target_link_libraries(simdjson-fuzzer INTERFACE simdjson-flags)
43+
target_link_libraries(simdjson-fuzzer INTERFACE simdjson-internal-flags)
4444
target_link_libraries(simdjson-fuzzer INTERFACE ${SIMDJSON_FUZZ_LDFLAGS})
4545

4646
# Define the fuzzers

‎simdjson-flags.cmake

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,39 +35,42 @@ set(THREADS_PREFER_PTHREAD_FLAG ON)
3535
# Flags used by exes and by the simdjson library (project-wide flags)
3636
#
3737
add_library(simdjson-flags INTERFACE)
38+
add_library(simdjson-internal-flags INTERFACE)
39+
target_link_libraries(simdjson-internal-flags INTERFACE simdjson-flags)
40+
3841
if(MSVC)
39-
target_compile_options(simdjson-flags INTERFACE /nologo /D_CRT_SECURE_NO_WARNINGS)
40-
target_compile_options(simdjson-flags INTERFACE /WX /W3 /sdl)
42+
target_compile_options(simdjson-internal-flags INTERFACE /nologo /D_CRT_SECURE_NO_WARNINGS)
43+
target_compile_options(simdjson-internal-flags INTERFACE /WX /W3 /sdl)
4144
else()
42-
target_compile_options(simdjson-flags INTERFACE -fPIC)
45+
target_compile_options(simdjson-internal-flags INTERFACE -fPIC)
4346
if (NOT SIMDJSON_GOOGLE_BENCHMARKS) # Google Benchmark can't be compiled without warnings with -Weffc++
44-
target_compile_options(simdjson-flags INTERFACE -Weffc++)
47+
target_compile_options(simdjson-internal-flags INTERFACE -Weffc++)
4548
endif()
46-
target_compile_options(simdjson-flags INTERFACE -Werror -Wall -Wextra -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion)
49+
target_compile_options(simdjson-internal-flags INTERFACE -Werror -Wall -Wextra -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion)
4750
endif()
4851

4952
# Optional flags
5053
option(SIMDJSON_IMPLEMENTATION_HASWELL "Include the haswell implementation" ON)
5154
if(NOT SIMDJSON_IMPLEMENTATION_HASWELL)
52-
target_compile_definitions(simdjson-flags INTERFACE SIMDJSON_IMPLEMENTATION_HASWELL=0)
55+
target_compile_definitions(simdjson-internal-flags INTERFACE SIMDJSON_IMPLEMENTATION_HASWELL=0)
5356
endif()
5457
option(SIMDJSON_IMPLEMENTATION_WESTMERE "Include the westmere implementation" ON)
5558
if(NOT SIMDJSON_IMPLEMENTATION_WESTMERE)
56-
target_compile_definitions(simdjson-flags INTERFACE SIMDJSON_IMPLEMENTATION_WESTMERE=0)
59+
target_compile_definitions(simdjson-internal-flags INTERFACE SIMDJSON_IMPLEMENTATION_WESTMERE=0)
5760
endif()
5861
option(SIMDJSON_IMPLEMENTATION_ARM64 "Include the arm64 implementation" ON)
5962
if(NOT SIMDJSON_IMPLEMENTATION_ARM64)
60-
target_compile_definitions(simdjson-flags INTERFACE SIMDJSON_IMPLEMENTATION_ARM64=0)
63+
target_compile_definitions(simdjson-internal-flags INTERFACE SIMDJSON_IMPLEMENTATION_ARM64=0)
6164
endif()
6265
option(SIMDJSON_IMPLEMENTATION_FALLBACK "Include the fallback implementation" ON)
6366
if(NOT SIMDJSON_IMPLEMENTATION_FALLBACK)
64-
target_compile_definitions(simdjson-flags INTERFACE SIMDJSON_IMPLEMENTATION_FALLBACK=0)
67+
target_compile_definitions(simdjson-internal-flags INTERFACE SIMDJSON_IMPLEMENTATION_FALLBACK=0)
6568
endif()
6669

6770
option(SIMDJSON_EXCEPTIONS "Enable simdjson's exception-throwing interface" ON)
6871
if(NOT SIMDJSON_EXCEPTIONS)
6972
message(STATUS "simdjson exception interface turned off. Code that does not check error codes will not compile.")
70-
target_compile_definitions(simdjson-flags INTERFACE SIMDJSON_EXCEPTIONS=0)
73+
target_compile_definitions(simdjson-internal-flags INTERFACE SIMDJSON_EXCEPTIONS=0)
7174
endif()
7275

7376
option(SIMDJSON_ENABLE_THREADS "Enable threaded operation" ON)
@@ -105,3 +108,4 @@ if(${CMAKE_C_COMPILER_ID} MATCHES "Intel") # icc / icpc
105108
endif()
106109

107110
install(TARGETS simdjson-flags EXPORT simdjson-config)
111+
install(TARGETS simdjson-internal-flags EXPORT simdjson-config)

‎singleheader/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ add_dependencies(simdjson-singleheader-source amalgamate)
9393
# Test the generated simdjson.cpp/simdjson.h using the generated amalgamate_demo.cpp
9494
#
9595
add_executable(amalgamate_demo $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/amalgamate_demo.cpp>)
96-
target_link_libraries(amalgamate_demo simdjson-singleheader-include-source simdjson-flags)
96+
target_link_libraries(amalgamate_demo simdjson-singleheader-include-source simdjson-internal-flags)
9797
add_test(amalgamate_demo amalgamate_demo ${EXAMPLE_JSON} ${EXAMPLE_NDJSON})
9898

9999
install(FILES simdjson.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

‎src/CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ else()
4242
endif()
4343
endif()
4444

45-
target_link_libraries(simdjson INTERFACE simdjson-headers) # Only expose the headers, not sources
46-
47-
target_link_libraries(simdjson PRIVATE simdjson-source simdjson-flags)
45+
target_link_libraries(simdjson PUBLIC simdjson-headers simdjson-flags) # Only expose the headers, not sources
46+
target_link_libraries(simdjson PRIVATE simdjson-source simdjson-internal-flags)
4847

4948

5049
if(NOT MSVC)

‎tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function(add_cpp_test TEST_NAME)
3535
endif()
3636
endfunction()
3737
# Most tests need test data, and many need windows headers.
38-
link_libraries(simdjson-flags test-data simdjson-windows-headers)
38+
link_libraries(simdjson-internal-flags test-data simdjson-windows-headers)
3939

4040
include(${PROJECT_SOURCE_DIR}/tests/add_cpp_test.cmake)
4141

‎tools/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
link_libraries(simdjson simdjson-flags simdjson-windows-headers)
1+
link_libraries(simdjson simdjson-internal-flags simdjson-windows-headers)
22

33
add_executable(json2json json2json.cpp)
44
add_executable(jsonstats jsonstats.cpp)

0 commit comments

Comments
 (0)