Skip to content

Commit a1bff85

Browse files
committed
Documenting the limits of move_to_key with respect to Unicode Equivalence.
1 parent fb920bb commit a1bff85

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

include/simdjson/parsedjsoniterator.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,17 @@ class ParsedJson::BasicIterator {
110110
// (in case of repeated keys, this only finds the first one).
111111
// We seek the key using C's strcmp so if your JSON strings contain
112112
// NULL chars, this would trigger a false positive: if you expect that
113-
// to be the case, take extra precautions.
113+
// to be the case, take extra precautions.
114+
// Furthermore, we do the comparison character-by-character
115+
// without taking into account Unicode equivalence.
114116
inline bool move_to_key(const char *key);
115117
// when at {, go one level deep, looking for a given key
116118
// if successful, we are left pointing at the value,
117119
// if not, we are still pointing at the object ({)
118120
// (in case of repeated keys, this only finds the first one).
119121
// The string we search for can contain NULL values.
122+
// Furthermore, we do the comparison character-by-character
123+
// without taking into account Unicode equivalence.
120124
inline bool move_to_key(const char *key, uint32_t length);
121125

122126
// when at a key location within an object, this moves to the accompanying

0 commit comments

Comments
 (0)