Merge pull request simdjson#975 from simdjson/dlemire/nitpicking_amal_demo

lemire · web-flow · commit a4ebdfd47ca8 · 2020-06-24T17:18:40.000-04:00
Nitpicking: demo should not crash on missing input
diff --git a/singleheader/amalgamate.sh b/singleheader/amalgamate.sh
@@ -132,6 +132,7 @@ cat <<< '
 int main(int argc, char *argv[]) {
   if(argc < 2) {
     std::cerr << "Please specify at least one file name. " << std::endl;
+    return EXIT_FAILURE;
   }
   const char * filename = argv[1];
   simdjson::dom::parser parser;
diff --git a/singleheader/amalgamate_demo.cpp b/singleheader/amalgamate_demo.cpp
@@ -6,6 +6,7 @@
 int main(int argc, char *argv[]) {
   if(argc < 2) {
     std::cerr << "Please specify at least one file name. " << std::endl;
+    return EXIT_FAILURE;
   }
   const char * filename = argv[1];
   simdjson::dom::parser parser;
@@ -42,4 +43,3 @@ int main(int argc, char *argv[]) {
   }
   return EXIT_SUCCESS;
 }
-

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ cat <<< '`
`132`	`132`	`int main(int argc, char *argv[]) {`
`133`	`133`	`if(argc < 2) {`
`134`	`134`	`std::cerr << "Please specify at least one file name. " << std::endl;`
	`135`	`+ return EXIT_FAILURE;`
`135`	`136`	`}`
`136`	`137`	`const char * filename = argv[1];`
`137`	`138`	`simdjson::dom::parser parser;`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`int main(int argc, char *argv[]) {`
`7`	`7`	`if(argc < 2) {`
`8`	`8`	`std::cerr << "Please specify at least one file name. " << std::endl;`
	`9`	`+ return EXIT_FAILURE;`
`9`	`10`	`}`
`10`	`11`	`const char * filename = argv[1];`
`11`	`12`	`simdjson::dom::parser parser;`
`@@ -42,4 +43,3 @@ int main(int argc, char *argv[]) {`
`42`	`43`	`}`
`43`	`44`	`return EXIT_SUCCESS;`
`44`	`45`	`}`
`45`		`-`