Skip to content

Commit f785f76

Browse files
jkeiserjkeiser
authored
Merge pull request simdjson#1342 from simdjson/jkeiser/iter-safety
Safety: assert in debug mode when on demand values are used out of order
2 parents c90ee57 + d670906 commit f785f76

34 files changed

+451
-249
lines changed

‎.appveyor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ environment:
1919
- job_name: VS2017 (Static, No Threads)
2020
image: Visual Studio 2017
2121
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
22-
CTEST_ARGS: -E checkperf
22+
CTEST_ARGS: -LE explicitonly
2323
- job_name: VS2019 (Win32)
2424
platform: Win32
2525
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_ENABLE_THREADS=ON # This should be the default. Testing anyway.
@@ -31,7 +31,7 @@ environment:
3131
- job_name: VS2015
3232
image: Visual Studio 2015
3333
CMAKE_ARGS: -A %Platform% -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_ENABLE_THREADS=OFF
34-
CTEST_ARGS: -E checkperf
34+
CTEST_ARGS: -LE explicitonly
3535

3636
build_script:
3737
- mkdir build

‎.circleci/config.yml

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,14 @@ commands:
103103
cd build &&
104104
tools/json2json -h &&
105105
ctest $CTEST_FLAGS -L acceptance &&
106-
ctest $CTEST_FLAGS -LE acceptance -E checkperf
106+
ctest $CTEST_FLAGS -LE acceptance -LE explicitonly
107+
108+
cmake_assert_test:
109+
steps:
110+
- run: |
111+
cd build &&
112+
tools/json2json -h &&
113+
ctest $CTEST_FLAGS -L assert
107114
108115
cmake_test_all:
109116
steps:
@@ -112,9 +119,9 @@ commands:
112119
cd build &&
113120
tools/json2json -h &&
114121
ctest $CTEST_FLAGS -DSIMDJSON_IMPLEMENTATION="haswell;westmere;fallback" -L acceptance -LE per_implementation &&
115-
SIMDJSON_FORCE_IMPLEMENTATION=haswell ctest $CTEST_FLAGS -L per_implementation -E checkperf &&
116-
SIMDJSON_FORCE_IMPLEMENTATION=westmere ctest $CTEST_FLAGS -L per_implementation -E checkperf &&
117-
SIMDJSON_FORCE_IMPLEMENTATION=fallback ctest $CTEST_FLAGS -L per_implementation -E checkperf &&
122+
SIMDJSON_FORCE_IMPLEMENTATION=haswell ctest $CTEST_FLAGS -L per_implementation -LE explicitonly &&
123+
SIMDJSON_FORCE_IMPLEMENTATION=westmere ctest $CTEST_FLAGS -L per_implementation -LE explicitonly &&
124+
SIMDJSON_FORCE_IMPLEMENTATION=fallback ctest $CTEST_FLAGS -L per_implementation -LE explicitonly &&
118125
ctest $CTEST_FLAGS -LE "acceptance|per_implementation" # Everything we haven't run yet, run now.
119126
120127
@@ -144,6 +151,16 @@ jobs:
144151
executor: gcc10
145152
environment: { CMAKE_FLAGS: -DSIMDJSON_JUST_LIBRARY=ON }
146153
steps: [ cmake_build, cmake_install_test, cmake_installed_test_cxx20 ]
154+
assert-gcc10:
155+
description: Build the library with asserts on, install it and run tests
156+
executor: gcc10
157+
environment: { CMAKE_FLAGS: -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DCMAKE_CXX_FLAGS_RELEASE=-O3 }
158+
steps: [ cmake_test, cmake_assert_test ]
159+
assert-clang10:
160+
description: Build just the library, install it and do a basic test
161+
executor: clang10
162+
environment: { CMAKE_FLAGS: -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DCMAKE_CXX_FLAGS_RELEASE=-O3 }
163+
steps: [ cmake_test, cmake_assert_test ]
147164
gcc10-perftest:
148165
description: Build and run performance tests on GCC 10 and AVX 2 with a cmake static build, this test performance regression
149166
executor: gcc10
@@ -174,22 +191,22 @@ jobs:
174191
sanitize-gcc10:
175192
description: Build and run tests on GCC 10 and AVX 2 with a cmake sanitize build
176193
executor: gcc10
177-
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -E checkperf }
194+
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -LE explicitonly }
178195
steps: [ cmake_test ]
179196
sanitize-clang10:
180197
description: Build and run tests on clang 10 and AVX 2 with a cmake sanitize build
181198
executor: clang10
182-
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, CTEST_FLAGS: --output-on-failure -E checkperf }
199+
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, CTEST_FLAGS: --output-on-failure -LE explicitonly }
183200
steps: [ cmake_test ]
184201
threadsanitize-gcc10:
185202
description: Build and run tests on GCC 10 and AVX 2 with a cmake sanitize build
186203
executor: gcc10
187-
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE_THREADS=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -E checkperf }
204+
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE_THREADS=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -LE explicitonly }
188205
steps: [ cmake_test ]
189206
threadsanitize-clang10:
190207
description: Build and run tests on clang 10 and AVX 2 with a cmake sanitize build
191208
executor: clang10
192-
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE_THREADS=ON, CTEST_FLAGS: --output-on-failure -E checkperf }
209+
environment: { CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE_THREADS=ON, CTEST_FLAGS: --output-on-failure -LE explicitonly }
193210
steps: [ cmake_test ]
194211
# dynamic
195212
dynamic-gcc10:
@@ -245,12 +262,12 @@ jobs:
245262
sanitize-haswell-gcc10:
246263
description: Build and run tests on GCC 10 and AVX 2 with a cmake sanitize build
247264
executor: gcc10
248-
environment: { CXXFLAGS: -march=haswell, CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -E checkperf }
265+
environment: { CXXFLAGS: -march=haswell, CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, BUILD_FLAGS: "", CTEST_FLAGS: --output-on-failure -LE explicitonly }
249266
steps: [ cmake_test ]
250267
sanitize-haswell-clang10:
251268
description: Build and run tests on clang 10 and AVX 2 with a cmake sanitize build
252269
executor: clang10
253-
environment: { CXXFLAGS: -march=haswell, CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, CTEST_FLAGS: --output-on-failure -E checkperf }
270+
environment: { CXXFLAGS: -march=haswell, CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF -DSIMDJSON_SANITIZE=ON, CTEST_FLAGS: --output-on-failure -LE explicitonly }
254271
steps: [ cmake_test ]
255272

256273
workflows:
@@ -292,4 +309,8 @@ workflows:
292309
# testing "just the library"
293310
- justlib-gcc10
294311

312+
# testing asserts
313+
- assert-gcc10
314+
- assert-clang10
315+
295316
# TODO add windows: https://circleci.com/docs/2.0/configuration-reference/#windows

‎.cirrus.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ task:
2323
- make
2424
test_script:
2525
- cd build
26-
- ctest --output-on-failure -E checkperf
26+
- ctest --output-on-failure -LE explicitonly

‎.drone.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ steps:
99
CXX: g++
1010
BUILD_FLAGS: -- -j
1111
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON
12-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
12+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
1313
commands:
1414
- scripts/addcmakeppa.sh "$(env -i sh -c '. /etc/os-release; echo $VERSION_CODENAME')"
1515
- apt-get install -y g++ cmake gcc git
@@ -30,7 +30,7 @@ steps:
3030
CXX: clang++-6.0
3131
BUILD_FLAGS: -- -j
3232
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON
33-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
33+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
3434
commands:
3535
- scripts/addcmakeppa.sh "$(env -i sh -c '. /etc/os-release; echo $VERSION_CODENAME')"
3636
- apt-get install -y clang++-6.0 cmake git
@@ -51,7 +51,7 @@ steps:
5151
CXX: g++
5252
BUILD_FLAGS: -- -j
5353
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_IMPLEMENTATION=haswell;westmere;fallback
54-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
54+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
5555
commands:
5656
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
5757
- apt-get update -qq
@@ -78,7 +78,7 @@ steps:
7878
CXX: clang++-6.0
7979
BUILD_FLAGS: -- -j
8080
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_IMPLEMENTATION=haswell;westmere;fallback
81-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
81+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
8282
commands:
8383
- mkdir build
8484
- cd build
@@ -101,7 +101,7 @@ steps:
101101
CXX: g++
102102
BUILD_FLAGS: -- -j
103103
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF
104-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
104+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
105105
commands:
106106
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
107107
- apt-get update -qq
@@ -124,7 +124,7 @@ steps:
124124
CXX: clang++-9
125125
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF
126126
BUILD_FLAGS: -- -j
127-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
127+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
128128
commands:
129129
- mkdir build
130130
- cd build
@@ -143,7 +143,7 @@ steps:
143143
CXX: g++
144144
BUILD_FLAGS: -- -j
145145
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_IMPLEMENTATION=haswell;westmere;fallback
146-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
146+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
147147
commands:
148148
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
149149
- apt-get update -qq
@@ -170,7 +170,7 @@ steps:
170170
CXX: clang++-9
171171
CMAKE_FLAGS: -DSIMDJSON_SANITIZE=ON -DSIMDJSON_IMPLEMENTATION=haswell;westmere;fallback
172172
BUILD_FLAGS: -- -j
173-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
173+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
174174
commands:
175175
- mkdir build
176176
- cd build
@@ -194,7 +194,7 @@ steps:
194194
CXX: clang++-11
195195
CMAKE_FLAGS: -GNinja
196196
BUILD_FLAGS:
197-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
197+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
198198
CXXFLAGS: -std=c++20 -stdlib=libc++
199199
commands:
200200
- mkdir build
@@ -214,7 +214,7 @@ steps:
214214
CXX: g++
215215
BUILD_FLAGS: -- -j
216216
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_IMPLEMENTATION=arm64;fallback
217-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
217+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
218218
commands:
219219
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
220220
- apt-get update -qq
@@ -239,7 +239,7 @@ steps:
239239
CXX: clang++-6.0
240240
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF
241241
BUILD_FLAGS: -- -j
242-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
242+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
243243
commands:
244244
- apt-get -qq update
245245
- apt-get -t buster-backports install -y cmake
@@ -261,7 +261,7 @@ steps:
261261
CXX: g++
262262
BUILD_FLAGS: -- -j
263263
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF
264-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
264+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
265265
commands:
266266
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
267267
- apt-get update -qq
@@ -283,7 +283,7 @@ steps:
283283
CXX: clang++-6.0
284284
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=OFF
285285
BUILD_FLAGS: -- -j
286-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
286+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
287287
commands:
288288
- apt-get -qq update
289289
- apt-get -t buster-backports install -y cmake
@@ -303,7 +303,7 @@ steps:
303303
environment:
304304
BUILD_FLAGS: -- -j
305305
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_IMPLEMENTATION=arm64;fallback
306-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
306+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
307307
CC: gcc
308308
CXX: g++
309309
commands:
@@ -331,7 +331,7 @@ steps:
331331
CXX: clang++-6.0
332332
CMAKE_FLAGS: -DSIMDJSON_SANITIZE=ON -DSIMDJSON_IMPLEMENTATION=arm64;fallback
333333
BUILD_FLAGS: -- -j
334-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
334+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
335335
commands:
336336
- apt-get -qq update
337337
- apt-get -t buster-backports install -y cmake
@@ -357,7 +357,7 @@ steps:
357357
CXX: clang++-9
358358
BUILD_FLAGS: -- -j 4
359359
CMAKE_FLAGS: -GNinja -DSIMDJSON_BUILD_STATIC=ON
360-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
360+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
361361
CXXFLAGS: -stdlib=libc++
362362
commands:
363363
- mkdir build
@@ -378,7 +378,7 @@ steps:
378378
CXX: clang++-9
379379
BUILD_FLAGS: -- -j
380380
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON
381-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
381+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
382382
CXXFLAGS: -stdlib=libc++
383383
commands:
384384
- mkdir build
@@ -399,7 +399,7 @@ steps:
399399
CXX: clang++-7
400400
BUILD_FLAGS: -- -j
401401
CMAKE_FLAGS: -DSIMDJSON_BUILD_STATIC=ON
402-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
402+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
403403
CXXFLAGS: -stdlib=libc++
404404
commands:
405405
- mkdir build
@@ -419,7 +419,7 @@ steps:
419419
CXX: g++
420420
BUILD_FLAGS: -- -j
421421
CMAKE_FLAGS: -DSIMDJSON_EXCEPTIONS=OFF
422-
CTEST_FLAGS: -j4 --output-on-failure -E checkperf
422+
CTEST_FLAGS: -j4 --output-on-failure -LE explicitonly
423423
commands:
424424
- echo "deb http://deb.debian.org/debian buster-backports main" >> /etc/apt/sources.list
425425
- apt-get update -qq

‎.github/workflows/alpine.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ jobs:
3434
./alpine.sh cmake --build build_for_alpine
3535
- name: test
3636
run: |
37-
./alpine.sh bash -c "cd build_for_alpine && ctest -E checkperf"
37+
./alpine.sh bash -c "cd build_for_alpine && ctest -LE explicitonly"

‎.github/workflows/msys2.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ jobs:
5151
cd build
5252
cmake -DCMAKE_BUILD_TYPE=${{ matrix.type }} -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_DO_NOT_USE_THREADS_NO_MATTER_WHAT=ON ..
5353
cmake --build . --verbose
54-
ctest -j4 --output-on-failure -E checkperf
54+
ctest -j4 --output-on-failure -LE explicitonly

‎.github/workflows/ubuntu18.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ jobs:
2323
cd build &&
2424
cmake -DSIMDJSON_GOOGLE_BENCHMARKS=ON -DSIMDJSON_BUILD_STATIC=ON -DCMAKE_INSTALL_PREFIX:PATH=destination .. &&
2525
cmake --build . &&
26-
ctest -j --output-on-failure -E checkperf &&
26+
ctest -j --output-on-failure -LE explicitonly &&
2727
make install &&
2828
echo -e '#include <simdjson.h>\nint main(int argc,char**argv) {simdjson::dom::parser parser;simdjson::dom::element tweets = parser.load(argv[1]); }' > tmp.cpp && c++ -Idestination/include -Ldestination/lib -std=c++17 -Wl,-rpath,destination/lib -o linkandrun tmp.cpp -lsimdjson && ./linkandrun jsonexamples/twitter.json

‎.github/workflows/ubuntu20.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ jobs:
2323
cd build &&
2424
cmake -DSIMDJSON_GOOGLE_BENCHMARKS=ON -DSIMDJSON_BUILD_STATIC=ON -DCMAKE_INSTALL_PREFIX:PATH=destination .. &&
2525
cmake --build . &&
26-
ctest -j --output-on-failure -E checkperf &&
26+
ctest -j --output-on-failure -LE explicitonly &&
2727
make install &&
2828
echo -e '#include <simdjson.h>\nint main(int argc,char**argv) {simdjson::dom::parser parser;simdjson::dom::element tweets = parser.load(argv[1]); }' > tmp.cpp && c++ -Idestination/include -Ldestination/lib -std=c++17 -Wl,-rpath,destination/lib -o linkandrun tmp.cpp -lsimdjson && ./linkandrun jsonexamples/twitter.json

‎.github/workflows/vs16-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ jobs:
3131
buildWithCMakeArgs: --config Release
3232

3333
- name: 'Run CTest'
34-
run: ctest -C Release -E checkperf --output-on-failure
34+
run: ctest -C Release -LE explicitonly --output-on-failure
3535
working-directory: "${{ github.workspace }}/../../_temp/windows"
3636

‎.github/workflows/vs16-clang-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ jobs:
3131
buildWithCMakeArgs: --config Release
3232

3333
- name: 'Run CTest'
34-
run: ctest -C Release -E checkperf --output-on-failure
34+
run: ctest -C Release -LE explicitonly --output-on-failure
3535
working-directory: "${{ github.workspace }}/../../_temp/windows"

‎.github/workflows/vs16-ninja-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ jobs:
3131
buildWithCMakeArgs: --config Release
3232

3333
- name: 'Run CTest'
34-
run: ctest -C Release -E checkperf --output-on-failure
34+
run: ctest -C Release -LE explicitonly --output-on-failure
3535
working-directory: "${{ github.workspace }}/../../_temp/windows"
3636

‎.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ install:
176176
- if [[ "${STATIC}" == "on" ]]; then
177177
export CMAKE_FLAGS="${CMAKE_FLAGS} -DSIMDJSON_BUILD_STATIC=ON";
178178
fi
179-
- export CTEST_FLAGS="-j4 --output-on-failure -E checkperf"
179+
- export CTEST_FLAGS="-j4 --output-on-failure -LE explicitonly"
180180

181181
script:
182182
- mkdir build

‎Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#
4242
# Next you can test it as follows:
4343
#
44-
# docker run -it -v $(pwd):/project:Z simdjson sh -c "cd dockerbuild && ctest . --output-on-failure -E checkperf"
44+
# docker run -it -v $(pwd):/project:Z simdjson sh -c "cd dockerbuild && ctest . --output-on-failure -LE explicitonly"
4545
#
4646
# The run the complete tests requires you to have built all of simdjson.
4747
#

‎benchmark/checkperf.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ if (Git_FOUND AND (GIT_VERSION_STRING VERSION_GREATER "2.1.4") AND (NOT CMAKE_G
8989
# COMMAND ECHO $<TARGET_FILE:perfdiff> \"$<TARGET_FILE:parse> -t ${SIMDJSON_CHECKPERF_ARGS}\" \"${CHECKPERF_PARSE} -t ${SIMDJSON_CHECKPERF_ARGS}\" }
9090
COMMAND $<TARGET_FILE:perfdiff> $<TARGET_FILE:parse> ${CHECKPERF_PARSE} -H -t ${SIMDJSON_CHECKPERF_ARGS}
9191
)
92-
set_property(TEST checkperf APPEND PROPERTY LABELS per_implementation)
92+
set_property(TEST checkperf APPEND PROPERTY LABELS per_implementation explicitonly)
9393
set_property(TEST checkperf APPEND PROPERTY DEPENDS parse perfdiff ${SIMDJSON_USER_CMAKECACHE})
9494
set_property(TEST checkperf PROPERTY RUN_SERIAL TRUE)
9595
else()

0 commit comments

Comments
 (0)