Skip to content

Merge with master #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 52 commits into
base: eris-sio_tls_support_non_tls_uris
Choose a base branch
from

Conversation

jmigual
Copy link

@jmigual jmigual commented Jun 30, 2023

I don't have maintainer push access to your branch.

I've merged master to your branch. Let's see if we can get this TLS rolling :)

Chris Grahn and others added 30 commits November 16, 2016 14:46
client_impl::close_impl() only gets called when the user is closing the
connection ("End by user"), when there is a handshake error, when the
server sends a frame_close packet ("End by server"), or when there is a
pong timeout.

Before, in the case where send_impl() would continously get called with
an interval less than client_impl::m_ping_interval, a disconnect due to
network problems would never be detected because the ping would keep
getting delayed, thus never allowing the pong timeout to happen. This
fixes that by not delaying pings.
If any errors occur while closing, such as TLS Short Read, we don't want
to reconnect if we had initiated the close.
Percent encode query string so it can handle non-ascii characters and
reserved characters.
Change client_impl::send_impl() not to delay ping
…close

Consider all client-initiated closes to be close_reason_normal.
Remove unused parameters and reorder constructors to get rid of warnings
- add the standalone ASIO as a replacement for Boost ASIO
- add Catch++ as a replacement for Boost Test framework
- remove dependency on Boost DateTime and Boost Lexical Cast
Due to the recent changes to the Travis CI platform (see [1]), we will
now use GitHub Actions to run the tests.

Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs

[1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
The 3rd revision is included in Socket.IO v1/v2, whereas the 4th is
included in Socket.IO v3.

Note: this query parameter is not currently checked on the server-side

Reference: https://github.com/socketio/engine.io-protocol
If CMake doesn't understand C++11-related property,
simply use the COMPILE_FLAGS property
Please note that this implementation differs from the JS one, where the
resource path is the namespace you want to reach:

```js
const socket = io("https://example.com/my-namespace", {
  path: "/my-custom-path/"
});
```

Here, we will have:

```C++
sio::client h;
h.connect("https://example.com/my-custom-path/");
h.socket("/my-namespace")->emit("hello");
```
The v4 contains only a few breaking changes at the API level on the
server-side, so the current C++ client is compatible.

Reference: https://socket.io/docs/v4/migrating-from-3-x-to-4-0/
Exposing include files for use in projects via FetchContent
gabrieljablonski and others added 22 commits November 23, 2021 23:44
Usage:

```c++
sio::client client;

sio::message::ptr auth = sio::object_message::create();
auth->get_map()["token"] = sio::string_message::create("eyJhbGciOiJIUzI1NiIsInR...");
auth->get_map()["sessionId"] = sio::string_message::create("p0ZoB1FwH6");

client.connect(server_url, auth);
```
Exposing include files for use in projects via FetchContent
Make non-cmake installation instructions mimic cmake
Bumps [ws](https://github.com/websockets/ws) from 7.4.2 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.2...7.4.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
As mentioned in socketio#67, Cocoapods is not supported at this time.
Signed-off-by: Patti Vacek <pattivacek@gmail.com>
* Update cmake for system install

* remove tooling hack

* CMake 3.4 is required so this is not needed

Co-authored-by: Joan Marcè i Igual <jmigual@users.noreply.github.com>

* Use submodules on ci

* Update .github/workflows/ci.yml

* Update CMakeLists.txt

Co-authored-by: Joan Marcè i Igual <jmigual@users.noreply.github.com>
* Change default submodules and fix install issue

The wrong target was used for installation of targets

* Disable flag as we changed the default
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.3 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.3...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: allow for custom io_service (socketio#390)

* Keep default constructor

---------

Co-authored-by: Joan Marcè i Igual <jmigual@users.noreply.github.com>
* build(deps): update catch2 from 1.10.0 to v3.3.2

* Use new catch version

* Fix test

* Remove catch submodule
@jmigual jmigual changed the base branch from master to eris-sio_tls_support_non_tls_uris June 30, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.