revert to using a simple shallowCopy for ops, since selectively copying is a breakign change if you've added new fields in middleware

nateps · nateps · commit ca1dca09e99f · 2019-11-04T13:14:57.000-08:00
diff --git a/lib/agent.js b/lib/agent.js
@@ -172,11 +172,7 @@ Agent.prototype._onOp = function(collection, id, op) {
   // before calling into projection and middleware code
   var agent = this;
   process.nextTick(function() {
-    var copy = shallowCopyOp(op);
-    if (!copy) {
-      logger.error('Op emitted from subscription failed to copy', collection, id, op);
-      return;
-    }
+    var copy = shallowCopy(op);
     agent.backend.sanitizeOp(agent, collection, id, copy, function(err) {
       if (err) {
         logger.error('Error sanitizing op emitted from subscription', collection, id, copy, err);
@@ -640,11 +636,12 @@ function createClientOp(request, clientId) {
         undefined;
 }
 
-function shallowCopyOp(op) {
-  return (op.op) ? new EditOp(op.src, op.seq, op.v, op.op, op.c, op.d, op.m) :
-    (op.create) ? new CreateOp(op.src, op.seq, op.v, op.create, op.c, op.d, op.m) :
-      (op.del) ? new DeleteOp(op.src, op.seq, op.v, op.del, op.c, op.d, op.m) :
-        undefined;
+function shallowCopy(object) {
+  var out = {};
+  for (var key in object) {
+    out[key] = object[key];
+  }
+  return out;
 }
 
 function CreateOp(src, seq, v, create, c, d, m) {
