Skip to content

Missing const in defineEmits #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ExEr7um opened this issue Aug 22, 2023 · 0 comments · Fixed by #56
Closed

Missing const in defineEmits #54

ExEr7um opened this issue Aug 22, 2023 · 0 comments · Fixed by #56
Assignees
@ExEr7um
Labels
Bug Something isn't working Good First Issue Good issue for new contributors

Comments

@ExEr7um
Copy link
Owner

ExEr7um commented Aug 22, 2023

defineEmits snippet looks like this:

defineEmits<{
  eventName: []
}>()

But I think it should always have const keyword.

const emit = defineEmits<{
  eventName: []
}>()
@ExEr7um ExEr7um added Bug Something isn't working Good First Issue Good issue for new contributors labels Aug 22, 2023
@ExEr7um ExEr7um self-assigned this Oct 8, 2023
ExEr7um added a commit that referenced this issue Oct 8, 2023
@ExEr7um
Add const emit = #54
b411896
@ExEr7um ExEr7um linked a pull request Oct 8, 2023 that will close this issue
fix: Missing const in defineEmits #56
Merged
ExEr7um added a commit that referenced this issue Oct 8, 2023
@ExEr7um
fix: Missing const in defineEmits (#56)
4001557 
Add `const emit =` #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ExEr7um ExEr7um

Labels
Bug Something isn't working Good First Issue Good issue for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Missing const in defineEmits ExEr7um/vue3-vscode-snippets
1 participant
@ExEr7um