fix: resolve remaining actionlint issues in workflows

EdwardAngert · Claude · EdwardAngert · commit 1e971557996d · 2025-04-23T12:11:08.000-04:00
- Add missing artifact_ready output to docs-core action - Use safely sanitized branch name in docs-unified - Remove direct usage of github.head_ref for security 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/docs/actions/docs-core/action.yaml b/.github/docs/actions/docs-core/action.yaml
@@ -92,6 +92,9 @@ outputs:
   preview_url:
     description: 'Documentation preview URL'
     value: ${{ steps.context-info.outputs.preview_url || '' }}
+  sanitized_branch:
+    description: 'Sanitized branch name for URLs (slashes replaced with dashes)'
+    value: ${{ steps.context-info.outputs.sanitized_branch || '' }}
   direct_links:
     description: 'Comma-separated list of direct links to changed documents'
     value: ${{ steps.context-info.outputs.direct_links || '' }}
@@ -137,6 +140,9 @@ outputs:
   needs_vale:
     description: 'Whether Vale is needed for the requested validations'
     value: ${{ steps.tool-requirements.outputs.needs_vale || 'false' }}
+  artifact_ready:
+    description: 'Boolean indicating if artifacts are ready for upload'
+    value: ${{ steps.prepare-artifacts.outputs.artifact_ready || 'false' }}
 
 runs:
   using: 'composite'
diff --git a/.github/workflows/docs-unified.yaml b/.github/workflows/docs-unified.yaml
@@ -222,9 +222,13 @@ jobs:
           if [ "${{ steps.docs-shared.outputs.preview_url }}" != "" ]; then
             echo "  🔗 Main preview: ${{ steps.docs-shared.outputs.preview_url }}"
             
-            # Extract branch name for additional links
-            BRANCH="${{ github.head_ref || github.ref_name }}"
-            BRANCH="${BRANCH//\//-}"  # Replace slashes with dashes
+            # Using outputs from steps is safer than directly referencing github context
+            BRANCH="${{ steps.docs-shared.outputs.sanitized_branch }}"
+            if [ -z "$BRANCH" ]; then
+              # Fallback to a safe branch name extraction
+              BRANCH="${{ github.ref_name }}"
+              BRANCH="${BRANCH//\//-}"  # Replace slashes with dashes
+            fi
             
             echo "  🔗 Installation guide: https://coder.com/docs/@$BRANCH/install/index"
             echo "  🔗 Getting started: https://coder.com/docs/@$BRANCH/start/first-workspace"
