refactor: improve changed files handling for Vale

EdwardAngert · Claude · EdwardAngert · commit 2173f53957c4 · 2025-04-23T15:59:51.000-04:00
- Mimic tj-actions/changed-files output format - Add both comma-separated and space-separated outputs - Better handle empty/null arrays with early exit - Improve readability with more descriptive comments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/workflows/docs-unified.yaml b/.github/workflows/docs-unified.yaml
@@ -127,21 +127,29 @@ jobs:
         
       # Vale style checking for documentation - only checks changed files
       # This is the ONLY place Vale is actually run - the action in docs-core is a placeholder
+      # Extract and format changed files for Vale in a way similar to tj-actions/changed-files
       - name: Extract changed files for Vale
         id: extract-changed-files
         if: steps.docs-core-setup.outputs.needs_vale == 'true' && steps.docs-core-setup.outputs.has_changes == 'true'
         shell: bash
         run: |
-          # Use the JSON array of changed files detected by docs-core
+          # Parse JSON array from docs-core output
           CHANGED_FILES_JSON='${{ steps.docs-core-setup.outputs.changed_files }}'
-          # Convert JSON array to comma-separated list
-          CHANGED_FILES=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(",")')
-          if [ -n "$CHANGED_FILES" ] && [ "$CHANGED_FILES" != "null" ]; then
-            echo "Files to check: $CHANGED_FILES"
-            echo "files_to_check=$CHANGED_FILES" >> $GITHUB_OUTPUT
-          else
+          
+          # Handle empty or null arrays
+          if [ "$CHANGED_FILES_JSON" == "[]" ] || [ "$CHANGED_FILES_JSON" == "null" ]; then
             echo "No files to check"
+            exit 0
           fi
+          
+          # Extract files as comma-separated string (Vale action input format)
+          CHANGED_FILES=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(",")')
+          echo "Files to check: $CHANGED_FILES"
+          echo "files_to_check=$CHANGED_FILES" >> $GITHUB_OUTPUT
+          
+          # Create space-separated output as well (like tj-actions/changed-files)
+          CHANGED_FILES_SPACES=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(" ")')
+          echo "all_changed_files=$CHANGED_FILES_SPACES" >> $GITHUB_OUTPUT
 
       - name: Run Vale style checks
         if: steps.docs-core-setup.outputs.needs_vale == 'true' && steps.extract-changed-files.outputs.files_to_check != ''
