Skip to content

Authentication #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 13, 2025
Merged

Authentication #368

merged 12 commits into from
Jun 13, 2025

Conversation

mrdavidorok
Copy link
Collaborator

Description

Added Pro tips, fixed some typos, and created a new image.

Linear ticket and magic word Fixes DEVR-943

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrdavidorok mrdavidorok marked this pull request as ready for review May 28, 2025 14:58
@github-actions github-actions bot requested a review from PoojaB26 May 28, 2025 14:58
Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR!
I've added comments to some portions but a lot of the comments apply to all files or most files so please take care of them by looking through each file. I'll repeat again, please read through our documentation guidelines and also read how some docs from the current site to understand our language and formatting style as that needs to be improved here! Thanks again.


It looks like you are experiencing an issue with using the Firebase Phone Authentication method. To troubleshoot this issue, there are a few things you can try:

Make sure you have correctly configured the Firebase Phone Authentication method in your app. This includes setting up a project in the Firebase console and adding the necessary dependencies to your app.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be in bullets


**Steps to follow in Apple Developer Account.**

Here I will guide you through all the steps you need to follow specifically in the Apple Developer account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the language we used in other docs, we don't use first person like "I will guide you"

Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PoojaB26 PoojaB26 merged commit cba8993 into main Jun 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants