chore(dogfood): update nodejs installation method (coder#11339)

matifali · web-flow · commit e3a1bdb60d8f · 2023-12-26T16:53:41.000+03:00
diff --git a/.github/workflows/dogfood.yaml b/.github/workflows/dogfood.yaml
@@ -14,7 +14,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  deploy_image:
+  build_image:
     runs-on: buildjet-4vcpu-ubuntu-2204
     steps:
       - name: Checkout
@@ -53,7 +53,7 @@ jobs:
           cache-to: type=inline
 
   deploy_template:
-    needs: deploy_image
+    needs: build_image
     if: github.ref == 'refs/heads/main'
     runs-on: ubuntu-latest
     steps:
diff --git a/dogfood/Dockerfile b/dogfood/Dockerfile
@@ -199,7 +199,6 @@ RUN LAZYGIT_VERSION=$(curl -s "https://api.github.com/repos/jesseduffield/lazygi
 # Install frontend utilities
 RUN apt-get update && \
 	# Node.js (from nodesource) and Yarn (from yarnpkg)
-	curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash - &&\
 	apt-get install --yes --quiet \
 	nodejs yarn \
 	# Install browsers for e2e testing
diff --git a/dogfood/files/etc/apt/sources.list.d/nodesource.list b/dogfood/files/etc/apt/sources.list.d/nodesource.list
@@ -1 +1 @@
-deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_16.x jammy main
+deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main
diff --git a/dogfood/files/usr/share/keyrings/nodesource.gpg b/dogfood/files/usr/share/keyrings/nodesource.gpg

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_16.x jammy main`
	`1`	`+deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main`