Remove some bad coding

moon-jam · moon-jam · commit 3800f9193ab8 · 2024-10-24T20:30:47.000+08:00
while True and ...
diff --git a/python/inputmodule/gui/ledmatrix.py b/python/inputmodule/gui/ledmatrix.py
@@ -25,7 +25,7 @@ def countdown(dev, seconds):
     set_status('countdown')
     start = datetime.now()
     target = seconds * 1_000_000
-    while True and get_status() == 'countdown':
+    while get_status() == 'countdown':
         if is_thread_stopped() or is_dev_disconnected(dev.device):
             reset_thread()
             return
@@ -51,7 +51,7 @@ def blinking(dev):
     """Blink brightness high/off every second.
     Keeps currently displayed grid"""
     set_status('blinking')
-    while True and get_status() == 'blinking':
+    while get_status() == 'blinking':
         if is_thread_stopped() or is_dev_disconnected(dev.device):
             reset_thread()
             return
@@ -65,7 +65,7 @@ def random_eq(dev):
     """Display an equlizer looking animation with random values."""
     animate(dev, False)
     set_status('random_eq')
-    while True and get_status() == 'random_eq':
+    while get_status() == 'random_eq':
         if is_thread_stopped() or is_dev_disconnected(dev.device):
             reset_thread()
             return
@@ -82,7 +82,7 @@ def clock(dev):
     Loops forever, updating every second"""
     animate(dev, False)
     set_status('clock')
-    while True and get_status() == 'clock':
+    while get_status() == 'clock':
         if is_thread_stopped() or is_dev_disconnected(dev.device):
             reset_thread()
             return
diff --git a/python/inputmodule/inputmodule/ledmatrix.py b/python/inputmodule/inputmodule/ledmatrix.py
@@ -124,7 +124,7 @@ def camera(dev):
         end_x = min(dim[1], start_x + WIDTH)
 
         # Pre-process the video into resized, cropped, grayscale frames
-        while True and get_status() == 'camera':
+        while get_status() == 'camera':
             ret, frame = capture.read()
             if not ret:
                 print("Failed to capture video frames")
@@ -166,7 +166,7 @@ def video(dev, video_file):
         processed = []
 
         # Pre-process the video into resized, cropped, grayscale frames
-        while True and get_status() == 'video':
+        while get_status() == 'video':
             ret, frame = capture.read()
             if not ret:
                 print("Failed to read video frames")
@@ -301,7 +301,7 @@ def breathing(dev):
     Keeps currently displayed grid"""
     set_status('breathing')
     # Bright ranges appear similar, so we have to go through those faster
-    while True and get_status() == 'breathing':
+    while get_status() == 'breathing':
         # Go quickly from 250 to 50
         for i in range(10):
             time.sleep(0.03)
