Skip to content

Commit 59798ff

Browse files
mrdoobmrdoob
committed
Simplified pyramides code. Normals aren't right though. Normals never were right anyway.
1 parent 8d33da6 commit 59798ff

File tree

3 files changed

+17
-39
lines changed

3 files changed

+17
-39
lines changed

‎examples/misc_camera_path.html

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -85,24 +85,15 @@
8585

8686
// world
8787

88-
var cube = new THREE.CubeGeometry( 20, 60, 20 );
89-
90-
cube.vertices[ 0 ].position.multiplyScalar( 0.01 );
91-
cube.vertices[ 1 ].position.multiplyScalar( 0.01 );
92-
cube.vertices[ 4 ].position.multiplyScalar( 0.01 );
93-
cube.vertices[ 5 ].position.multiplyScalar( 0.01 );
94-
95-
var material = new THREE.MeshLambertMaterial( { color:0xffffff } );
88+
var geometry = new THREE.CylinderGeometry( 0, 10, 30, 4, 1 );
89+
var material = new THREE.MeshLambertMaterial( { color:0xffffff, shading: THREE.FlatShading } );
9690

9791
for ( var i = 0; i < 500; i ++ ) {
9892

99-
var mesh = new THREE.Mesh( cube, material );
100-
mesh.position.set(
101-
( Math.random() - 0.5 ) * 1000,
102-
( Math.random() - 0.5 ) * 1000,
103-
( Math.random() - 0.5 ) * 1000
104-
);
105-
93+
var mesh = new THREE.Mesh( geometry, material );
94+
mesh.position.x = ( Math.random() - 0.5 ) * 1000;
95+
mesh.position.y = ( Math.random() - 0.5 ) * 1000;
96+
mesh.position.z = ( Math.random() - 0.5 ) * 1000;
10697
mesh.updateMatrix();
10798
mesh.matrixAutoUpdate = false;
10899
scene.add( mesh );

‎examples/misc_camera_roll.html

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -75,22 +75,15 @@
7575

7676
// world
7777

78-
var cube = new THREE.CubeGeometry( 20, 60, 20 );
78+
var geometry = new THREE.CylinderGeometry( 0, 10, 30, 4, 1 );
79+
var material = new THREE.MeshLambertMaterial( { color:0xffffff, shading: THREE.FlatShading } );
7980

80-
cube.vertices[ 0 ].position.multiplyScalar( 0.01 );
81-
cube.vertices[ 1 ].position.multiplyScalar( 0.01 );
82-
cube.vertices[ 4 ].position.multiplyScalar( 0.01 );
83-
cube.vertices[ 5 ].position.multiplyScalar( 0.01 );
84-
85-
var material = new THREE.MeshLambertMaterial( { color:0xffffff } );
86-
87-
for( var i = 0; i < 500; i++ ) {
88-
89-
var mesh = new THREE.Mesh( cube, material );
90-
mesh.position.set(( Math.random() - 0.5 ) * 1000,
91-
( Math.random() - 0.5 ) * 1000,
92-
( Math.random() - 0.5 ) * 1000 );
81+
for ( var i = 0; i < 500; i ++ ) {
9382

83+
var mesh = new THREE.Mesh( geometry, material );
84+
mesh.position.x = ( Math.random() - 0.5 ) * 1000;
85+
mesh.position.y = ( Math.random() - 0.5 ) * 1000;
86+
mesh.position.z = ( Math.random() - 0.5 ) * 1000;
9487
mesh.updateMatrix();
9588
mesh.matrixAutoUpdate = false;
9689
scene.add( mesh );

‎examples/misc_camera_trackball.html

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,12 @@
8585

8686
// world
8787

88-
var cube = new THREE.CubeGeometry( 20, 60, 20 );
88+
var geometry = new THREE.CylinderGeometry( 0, 10, 30, 4, 1 );
89+
var material = new THREE.MeshLambertMaterial( { color:0xffffff, shading: THREE.FlatShading } );
8990

90-
cube.vertices[ 0 ].position.multiplyScalar( 0.01 );
91-
cube.vertices[ 1 ].position.multiplyScalar( 0.01 );
92-
cube.vertices[ 4 ].position.multiplyScalar( 0.01 );
93-
cube.vertices[ 5 ].position.multiplyScalar( 0.01 );
91+
for ( var i = 0; i < 500; i ++ ) {
9492

95-
var material = new THREE.MeshLambertMaterial( { color: 0xffffff } );
96-
97-
for( var i = 0; i < 500; i ++ ) {
98-
99-
var mesh = new THREE.Mesh( cube, material );
93+
var mesh = new THREE.Mesh( geometry, material );
10094
mesh.position.x = ( Math.random() - 0.5 ) * 1000;
10195
mesh.position.y = ( Math.random() - 0.5 ) * 1000;
10296
mesh.position.z = ( Math.random() - 0.5 ) * 1000;

0 commit comments

Comments
 (0)