Rework datatable definitions for testing

Nicolas Rodriguez · Nicolas Rodriguez · commit 14e4bbe05b81 · 2017-07-19T00:23:29.000+02:00
diff --git a/spec/ajax-datatables-rails/base_spec.rb b/spec/ajax-datatables-rails/base_spec.rb
@@ -25,11 +25,6 @@
       end
 
       context 'child class implements view_columns' do
-        it 'expects an array based defining columns' do
-          datatable = SampleDatatable.new(view)
-          expect(datatable.view_columns).to be_a(Array)
-        end
-
         it 'expects a hash based defining columns' do
           datatable = ComplexDatatable.new(view)
           expect(datatable.view_columns).to be_a(Hash)
@@ -51,7 +46,7 @@
       end
 
       context 'when data is defined as a hash' do
-        let(:datatable) { ComplexDatatableHash.new(view) }
+        let(:datatable) { ComplexDatatable.new(view) }
 
         it 'should return an array of hashes' do
           create_list(:user, 5)
@@ -92,7 +87,7 @@
     end
 
     describe '#as_json' do
-      let(:datatable) { ComplexDatatableHash.new(view) }
+      let(:datatable) { ComplexDatatable.new(view) }
 
       it 'should return a hash' do
         create_list(:user, 5)
diff --git a/spec/ajax-datatables-rails/datatable/column_spec.rb b/spec/ajax-datatables-rails/datatable/column_spec.rb
@@ -81,6 +81,7 @@
   end
 
   describe '#formater' do
+    let(:datatable) { DatatableWithFormater.new(view) }
     let(:column) { datatable.datatable.columns.find { |c| c.data == 'last_name' } }
 
     it 'should be a proc' do
@@ -89,7 +90,7 @@
   end
 
   describe '#filter' do
-    let(:datatable) { ReallyComplexDatatableProc.new(view) }
+    let(:datatable) { DatatableCondProc.new(view) }
     let(:column) { datatable.datatable.columns.find { |c| c.data == 'username' } }
 
     it 'should be a proc' do
diff --git a/spec/ajax-datatables-rails/extended_spec.rb b/spec/ajax-datatables-rails/extended_spec.rb
@@ -2,7 +2,7 @@
 
 describe AjaxDatatablesRails::Base do
   let(:view) { double('view', params: sample_params) }
-  let(:datatable) { ReallyComplexDatatable.new(view) }
+  let(:datatable) { DatatableWithFormater.new(view) }
 
   describe 'it can transform search value before asking the database' do
     before(:each) do
diff --git a/spec/ajax-datatables-rails/orm/active_record_filter_records_spec.rb b/spec/ajax-datatables-rails/orm/active_record_filter_records_spec.rb
@@ -234,10 +234,10 @@
   end
 
   describe 'filter conditions' do
-    let(:datatable) { ReallyComplexDatatable.new(view) }
-
     unless AjaxDatatablesRails.old_rails?
       describe 'it can filter records with condition :date_range' do
+        let(:datatable) { DatatableCondDate.new(view) }
+
         before(:each) do
           create(:user, username: 'johndoe', email: 'johndoe@example.com', last_name: 'Doe', created_at: '01/01/2000')
           create(:user, username: 'msmith', email: 'mary.smith@example.com', last_name: 'Smith', created_at: '01/02/2000')
@@ -318,6 +318,8 @@
     end
 
     describe 'it can filter records with condition :start_with' do
+      let(:datatable) { DatatableCondStartWith.new(view) }
+
       before(:each) do
         create(:user, first_name: 'John')
         create(:user, first_name: 'Mary')
@@ -332,6 +334,8 @@
     end
 
     describe 'it can filter records with condition :end_with' do
+      let(:datatable) { DatatableCondEndWith.new(view) }
+
       before(:each) do
         create(:user, last_name: 'JOHN')
         create(:user, last_name: 'MARY')
@@ -346,6 +350,8 @@
     end
 
     describe 'it can filter records with condition :null_value' do
+      let(:datatable) { DatatableCondNullValue.new(view) }
+
       before(:each) do
         create(:user, first_name: 'john', email: 'foo@bar.com')
         create(:user, first_name: 'mary', email: nil)
@@ -371,7 +377,7 @@
     end
 
     describe 'it can filter records with condition :eq' do
-      let(:datatable) { ReallyComplexDatatableEq.new(view) }
+      let(:datatable) { DatatableCondEq.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -387,7 +393,7 @@
     end
 
     describe 'it can filter records with condition :not_eq' do
-      let(:datatable) { ReallyComplexDatatableNotEq.new(view) }
+      let(:datatable) { DatatableCondNotEq.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -403,7 +409,7 @@
     end
 
     describe 'it can filter records with condition :lt' do
-      let(:datatable) { ReallyComplexDatatableLt.new(view) }
+      let(:datatable) { DatatableCondLt.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -419,7 +425,7 @@
     end
 
     describe 'it can filter records with condition :gt' do
-      let(:datatable) { ReallyComplexDatatableGt.new(view) }
+      let(:datatable) { DatatableCondGt.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -435,7 +441,7 @@
     end
 
     describe 'it can filter records with condition :lteq' do
-      let(:datatable) { ReallyComplexDatatableLteq.new(view) }
+      let(:datatable) { DatatableCondLteq.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -449,7 +455,7 @@
     end
 
     describe 'it can filter records with condition :gteq' do
-      let(:datatable) { ReallyComplexDatatableGteq.new(view) }
+      let(:datatable) { DatatableCondGteq.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
@@ -463,7 +469,7 @@
     end
 
     describe 'it can filter records with condition :in' do
-      let(:datatable) { ReallyComplexDatatableIn.new(view) }
+      let(:datatable) { DatatableCondIn.new(view) }
 
       before(:each) do
         create(:user, first_name: 'john', post_id: 1)
diff --git a/spec/ajax-datatables-rails/orm/active_record_paginate_records_spec.rb b/spec/ajax-datatables-rails/orm/active_record_paginate_records_spec.rb
@@ -3,7 +3,7 @@
 describe AjaxDatatablesRails::ORM::ActiveRecord do
 
   let(:view) { double('view', params: sample_params) }
-  let(:datatable) { SampleDatatable.new(view) }
+  let(:datatable) { ComplexDatatable.new(view) }
   let(:records) { User.all }
 
   before(:each) do
diff --git a/spec/ajax-datatables-rails/orm/active_record_spec.rb b/spec/ajax-datatables-rails/orm/active_record_spec.rb
@@ -3,7 +3,7 @@
 describe AjaxDatatablesRails::ORM::ActiveRecord do
   context 'Private API' do
     let(:view) { double('view', params: sample_params) }
-    let(:datatable) { SampleDatatable.new(view) }
+    let(:datatable) { ComplexDatatable.new(view) }
 
     before(:each) do
       create(:user, username: 'johndoe', email: 'johndoe@example.com')
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -78,4 +78,8 @@
 
 load File.dirname(__FILE__) + '/support/schema.rb'
 load File.dirname(__FILE__) + '/support/test_helpers.rb'
+load File.dirname(__FILE__) + '/support/datatable_cond_date.rb'
+load File.dirname(__FILE__) + '/support/datatable_cond_numeric.rb'
+load File.dirname(__FILE__) + '/support/datatable_cond_proc.rb'
+load File.dirname(__FILE__) + '/support/datatable_cond_string.rb'
 require File.dirname(__FILE__) + '/support/test_models.rb'
diff --git a/spec/support/datatable_cond_date.rb b/spec/support/datatable_cond_date.rb
@@ -0,0 +1,5 @@
+class DatatableCondDate < ComplexDatatable
+  def view_columns
+    super.deep_merge(created_at: { cond: :date_range })
+  end
+end
diff --git a/spec/support/datatable_cond_numeric.rb b/spec/support/datatable_cond_numeric.rb
@@ -0,0 +1,41 @@
+class DatatableCondEq < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :eq })
+  end
+end
+
+class DatatableCondNotEq < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :not_eq })
+  end
+end
+
+class DatatableCondLt < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :lt })
+  end
+end
+
+class DatatableCondGt < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :gt })
+  end
+end
+
+class DatatableCondLteq < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :lteq })
+  end
+end
+
+class DatatableCondGteq < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :gteq })
+  end
+end
+
+class DatatableCondIn < ComplexDatatable
+  def view_columns
+    super.deep_merge(post_id: { cond: :in })
+  end
+end
diff --git a/spec/support/datatable_cond_proc.rb b/spec/support/datatable_cond_proc.rb
@@ -0,0 +1,11 @@
+class DatatableCondProc < ComplexDatatable
+  def view_columns
+    super.deep_merge(username: { cond: custom_filter })
+  end
+
+  private
+
+  def custom_filter
+    ->(column, value) { ::Arel::Nodes::SqlLiteral.new(column.field.to_s).matches("#{value}%") }
+  end
+end
diff --git a/spec/support/datatable_cond_string.rb b/spec/support/datatable_cond_string.rb
@@ -0,0 +1,23 @@
+class DatatableCondStartWith < ComplexDatatable
+  def view_columns
+    super.deep_merge(first_name: { cond: :start_with })
+  end
+end
+
+class DatatableCondEndWith < ComplexDatatable
+  def view_columns
+    super.deep_merge(last_name: { cond: :end_with })
+  end
+end
+
+class DatatableCondNullValue < ComplexDatatable
+  def view_columns
+    super.deep_merge(email: { cond: :null_value })
+  end
+end
+
+class DatatableWithFormater < ComplexDatatable
+  def view_columns
+    super.deep_merge(last_name: { formater: -> (o) { o.upcase } })
+  end
+end
diff --git a/spec/support/test_helpers.rb b/spec/support/test_helpers.rb
