Raise exception if given a bad topic name (dpkp#824)

ssaamm · dpkp · commit 5ad6f52a802c · 2016-11-20T12:43:26.000-08:00
diff --git a/kafka/consumer/subscription_state.py b/kafka/consumer/subscription_state.py
@@ -128,15 +128,22 @@ def change_subscription(self, topics):
 
         Raises:
             IllegalStateErrror: if assign_from_user has been used already
+            TypeError: if a non-str topic is given
         """
         if self._user_assignment:
             raise IllegalStateError(self._SUBSCRIPTION_EXCEPTION_MESSAGE)
 
+        if isinstance(topics, str):
+            topics = [topics]
+
         if self.subscription == set(topics):
             log.warning("subscription unchanged by change_subscription(%s)",
                         topics)
             return
 
+        if any(not isinstance(t, str) for t in topics):
+            raise TypeError('All topics must be strings')
+
         log.info('Updating subscribed topics to: %s', topics)
         self.subscription = set(topics)
         self._group_subscription.update(topics)
