diff --git a/CHANGELOG.md b/CHANGELOG.md index 58adafda..8ad1f6d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,13 @@ [1]: https://www.npmjs.com/package/@google-cloud/functions-framework?activeTab=versions +## [3.4.6](https://github.com/GoogleCloudPlatform/functions-framework-nodejs/compare/v3.4.5...v3.4.6) (2025-03-04) + + +### Bug Fixes + +* remove logger.errorHandler. ([#676](https://github.com/GoogleCloudPlatform/functions-framework-nodejs/issues/676)) ([a5394d5](https://github.com/GoogleCloudPlatform/functions-framework-nodejs/commit/a5394d56dfd4f6044f2a55dcd423155ce9069b77)) + ## [3.4.5](https://github.com/GoogleCloudPlatform/functions-framework-nodejs/compare/v3.4.4...v3.4.5) (2024-12-26) diff --git a/package-lock.json b/package-lock.json index 1f908f91..82460555 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@google-cloud/functions-framework", - "version": "3.4.5", + "version": "3.4.6", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@google-cloud/functions-framework", - "version": "3.4.5", + "version": "3.4.6", "license": "Apache-2.0", "dependencies": { "@types/express": "^5.0.0", @@ -26,7 +26,7 @@ "@microsoft/api-extractor": "^7.48.0", "@types/body-parser": "1.19.5", "@types/minimist": "1.2.5", - "@types/mocha": "^9.1.1", + "@types/mocha": "^10.0.0", "@types/node": "^22.10.1", "@types/on-finished": "2.3.4", "@types/semver": "^7.5.8", @@ -643,9 +643,9 @@ "dev": true }, "node_modules/@types/mocha": { - "version": "9.1.1", - "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-9.1.1.tgz", - "integrity": "sha512-Z61JK7DKDtdKTWwLeElSEBcWGRLY8g95ic5FoQqI9CMx0ns/Ghep3B4DfcEimiKMvtamNVULVNKEsiwV3aQmXw==", + "version": "10.0.10", + "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-10.0.10.tgz", + "integrity": "sha512-xPyYSz1cMPnJQhl0CLMH68j3gprKZaTjG3s5Vi+fDgx+uhG9NOXwbVt52eFS8ECyXhyKcjDLCBEqBExKuiZb7Q==", "dev": true }, "node_modules/@types/node": { @@ -6114,9 +6114,9 @@ "dev": true }, "@types/mocha": { - "version": "9.1.1", - "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-9.1.1.tgz", - "integrity": "sha512-Z61JK7DKDtdKTWwLeElSEBcWGRLY8g95ic5FoQqI9CMx0ns/Ghep3B4DfcEimiKMvtamNVULVNKEsiwV3aQmXw==", + "version": "10.0.10", + "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-10.0.10.tgz", + "integrity": "sha512-xPyYSz1cMPnJQhl0CLMH68j3gprKZaTjG3s5Vi+fDgx+uhG9NOXwbVt52eFS8ECyXhyKcjDLCBEqBExKuiZb7Q==", "dev": true }, "@types/node": { @@ -9740,4 +9740,4 @@ "dev": true } } -} \ No newline at end of file +} diff --git a/package.json b/package.json index 253afd99..21a892c2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@google-cloud/functions-framework", - "version": "3.4.5", + "version": "3.4.6", "description": "FaaS (Function as a service) framework for writing portable Node.js functions", "engines": { "node": ">=10.0.0" @@ -55,7 +55,7 @@ "@microsoft/api-extractor": "^7.48.0", "@types/body-parser": "1.19.5", "@types/minimist": "1.2.5", - "@types/mocha": "^9.1.1", + "@types/mocha": "^10.0.0", "@types/node": "^22.10.1", "@types/on-finished": "2.3.4", "@types/semver": "^7.5.8", diff --git a/src/logger.ts b/src/logger.ts index 6f81b4cb..dfb1f3a7 100644 --- a/src/logger.ts +++ b/src/logger.ts @@ -90,17 +90,6 @@ function interceptStderrWrite() { }; } -export const errorHandler = ( - // eslint-disable-next-line @typescript-eslint/no-explicit-any - err: Error | any, - req: express.Request, // eslint-disable-line @typescript-eslint/no-unused-vars - res: express.Response, - next: express.NextFunction // eslint-disable-line @typescript-eslint/no-unused-vars -) => { - interceptStderrWrite(); - sendCrashResponse({err, res}); -}; - // eslint-disable-next-line @typescript-eslint/no-explicit-any export function splitArgs(args: any[]) { let encoding, cb; diff --git a/src/server.ts b/src/server.ts index e8ce7451..bc348141 100644 --- a/src/server.ts +++ b/src/server.ts @@ -25,7 +25,6 @@ import {timeoutMiddleware} from './middleware/timeout'; import {wrapUserFunction} from './function_wrappers'; import {asyncLocalStorageMiddleware} from './async_local_storage'; import {executionContextMiddleware} from './execution_context'; -import {errorHandler} from './logger'; import {FrameworkOptions} from './options'; /** @@ -161,10 +160,5 @@ export function getServer( app.post('/*', requestHandler); } - // Error Handler - if (options.enableExecutionId) { - app.use(errorHandler); - } - return http.createServer(app); }